From 8db49cc2de52033990ae5d4d6aacedc8f986e803 Mon Sep 17 00:00:00 2001 From: Will Newton Date: Thu, 31 Oct 2013 17:21:11 -0700 Subject: [PATCH] config/tc-aarch64.c: Avoid trying to parse a vector mov as immediate. Parsing a vector mov instruction currently leads to a phantom undefined symbol being added to the symbol table. e.g.: .text mov x0, v0.D[0] Produces an undefined symbol called "v0.D". gas/ChangeLog: 2013-11-05 Will Newton PR gas/16103 * config/tc-aarch64.c (parse_operands): Avoid trying to parse a vector register as an immediate. gas/testsuite/ChangeLog: 2013-11-05 Will Newton * gas/aarch64/advsimd-mov-bad.d: New file. * gas/aarch64/advsimd-mov-bad.s: Likewise. --- gas/ChangeLog | 6 ++++++ gas/config/tc-aarch64.c | 3 ++- gas/testsuite/ChangeLog | 5 +++++ gas/testsuite/gas/aarch64/advsimd-mov-bad.d | 12 ++++++++++++ gas/testsuite/gas/aarch64/advsimd-mov-bad.s | 2 ++ 5 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 gas/testsuite/gas/aarch64/advsimd-mov-bad.d create mode 100644 gas/testsuite/gas/aarch64/advsimd-mov-bad.s diff --git a/gas/ChangeLog b/gas/ChangeLog index b5202e0511b..7078b22dfb1 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,9 @@ +2013-11-05 Will Newton + + PR gas/16103 + * config/tc-aarch64.c (parse_operands): Avoid trying to + parse a vector register as an immediate. + 2013-11-04 Jan Beulich * config/tc-i386.c (check_long_reg): Correct comment indentation. diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c index 14ffdadc139..02fe4de04ae 100644 --- a/gas/config/tc-aarch64.c +++ b/gas/config/tc-aarch64.c @@ -4810,7 +4810,8 @@ parse_operands (char *str, const aarch64_opcode *opcode) case AARCH64_OPND_IMM_MOV: { char *saved = str; - if (reg_name_p (str, REG_TYPE_R_Z_SP)) + if (reg_name_p (str, REG_TYPE_R_Z_SP) || + reg_name_p (str, REG_TYPE_VN)) goto failure; str = saved; po_misc_or_fail (my_get_expression (&inst.reloc.exp, &str, diff --git a/gas/testsuite/ChangeLog b/gas/testsuite/ChangeLog index 1d01b33446b..19a61388b84 100644 --- a/gas/testsuite/ChangeLog +++ b/gas/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2013-11-05 Will Newton + + * gas/aarch64/advsimd-mov-bad.d: New file. + * gas/aarch64/advsimd-mov-bad.s: Likewise. + 2013-11-04 Jan Beulich * gas/i386/x86-64-suffix-bad.[sl]: New. diff --git a/gas/testsuite/gas/aarch64/advsimd-mov-bad.d b/gas/testsuite/gas/aarch64/advsimd-mov-bad.d new file mode 100644 index 00000000000..6ca98873ac2 --- /dev/null +++ b/gas/testsuite/gas/aarch64/advsimd-mov-bad.d @@ -0,0 +1,12 @@ +#source: advsimd-mov-bad.s +#readelf: -s --wide + +Symbol table '.symtab' contains 6 entries: + +Num:.* + +[0-9]+:.* + +[0-9]+:.* + +[0-9]+:.* + +[0-9]+:.* + +[0-9]+:.* +#failif + +[0-9]+: +[0-9a-f]+ +0 +NOTYPE +GLOBAL +DEFAULT +UND v0.D diff --git a/gas/testsuite/gas/aarch64/advsimd-mov-bad.s b/gas/testsuite/gas/aarch64/advsimd-mov-bad.s new file mode 100644 index 00000000000..d7ba2262a50 --- /dev/null +++ b/gas/testsuite/gas/aarch64/advsimd-mov-bad.s @@ -0,0 +1,2 @@ + .text + mov x0, v0.D[0] -- 2.30.2