From 8dbb13755bd15eea33df1dec1c6171f745d9f501 Mon Sep 17 00:00:00 2001 From: Hannes Domani Date: Fri, 1 May 2020 14:01:02 +0200 Subject: [PATCH] Fix size recalculation of fortran arrays My recent change regarding size calculation of arrays of stubbed types didn't take array strides and associated/allocated type properties into account, which basically broke fortran arrays. Fixed by refactoring the array size calculation of create_array_type_with_stride into a new function, and also use it for the stubbed array size recalculation. gdb/ChangeLog: 2020-05-01 Hannes Domani * gdbtypes.c (update_static_array_size): New function. (create_array_type_with_stride): Use update_static_array_size. (check_typedef): Likewise. --- gdb/gdbtypes.c | 132 ++++++++++++++++++++++++++----------------------- 1 file changed, 70 insertions(+), 62 deletions(-) diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index 6648dc4d678..93ef8774a91 100644 --- a/gdb/gdbtypes.c +++ b/gdb/gdbtypes.c @@ -1177,6 +1177,64 @@ discrete_position (struct type *type, LONGEST val, LONGEST *pos) } } +/* If the array TYPE has static bounds calculate and update its + size, then return true. Otherwise return false and leave TYPE + unchanged. */ + +static bool +update_static_array_size (struct type *type) +{ + gdb_assert (TYPE_CODE (type) == TYPE_CODE_ARRAY); + + struct type *range_type = TYPE_INDEX_TYPE (type); + + if (get_dyn_prop (DYN_PROP_BYTE_STRIDE, type) == nullptr + && has_static_range (TYPE_RANGE_DATA (range_type)) + && (!type_not_associated (type) + && !type_not_allocated (type))) + { + LONGEST low_bound, high_bound; + int stride; + struct type *element_type; + + /* If the array itself doesn't provide a stride value then take + whatever stride the range provides. Don't update BIT_STRIDE as + we don't want to place the stride value from the range into this + arrays bit size field. */ + stride = TYPE_FIELD_BITSIZE (type, 0); + if (stride == 0) + stride = TYPE_BIT_STRIDE (range_type); + + if (get_discrete_bounds (range_type, &low_bound, &high_bound) < 0) + low_bound = high_bound = 0; + element_type = check_typedef (TYPE_TARGET_TYPE (type)); + /* Be careful when setting the array length. Ada arrays can be + empty arrays with the high_bound being smaller than the low_bound. + In such cases, the array length should be zero. */ + if (high_bound < low_bound) + TYPE_LENGTH (type) = 0; + else if (stride != 0) + { + /* Ensure that the type length is always positive, even in the + case where (for example in Fortran) we have a negative + stride. It is possible to have a single element array with a + negative stride in Fortran (this doesn't mean anything + special, it's still just a single element array) so do + consider that case when touching this code. */ + LONGEST element_count = std::abs (high_bound - low_bound + 1); + TYPE_LENGTH (type) + = ((std::abs (stride) * element_count) + 7) / 8; + } + else + TYPE_LENGTH (type) = + TYPE_LENGTH (element_type) * (high_bound - low_bound + 1); + + return true; + } + + return false; +} + /* Create an array type using either a blank type supplied in RESULT_TYPE, or creating a new type, inheriting the objfile from RANGE_TYPE. @@ -1222,47 +1280,17 @@ create_array_type_with_stride (struct type *result_type, TYPE_CODE (result_type) = TYPE_CODE_ARRAY; TYPE_TARGET_TYPE (result_type) = element_type; - if (byte_stride_prop == NULL - && has_static_range (TYPE_RANGE_DATA (range_type)) - && (!type_not_associated (result_type) - && !type_not_allocated (result_type))) - { - LONGEST low_bound, high_bound; - int stride; - /* If the array itself doesn't provide a stride value then take - whatever stride the range provides. Don't update BIT_STRIDE as - we don't want to place the stride value from the range into this - arrays bit size field. */ - stride = bit_stride; - if (stride == 0) - stride = TYPE_BIT_STRIDE (range_type); + TYPE_NFIELDS (result_type) = 1; + TYPE_FIELDS (result_type) = + (struct field *) TYPE_ZALLOC (result_type, sizeof (struct field)); + TYPE_INDEX_TYPE (result_type) = range_type; + if (byte_stride_prop != NULL) + add_dyn_prop (DYN_PROP_BYTE_STRIDE, *byte_stride_prop, result_type); + else if (bit_stride > 0) + TYPE_FIELD_BITSIZE (result_type, 0) = bit_stride; - if (get_discrete_bounds (range_type, &low_bound, &high_bound) < 0) - low_bound = high_bound = 0; - element_type = check_typedef (element_type); - /* Be careful when setting the array length. Ada arrays can be - empty arrays with the high_bound being smaller than the low_bound. - In such cases, the array length should be zero. */ - if (high_bound < low_bound) - TYPE_LENGTH (result_type) = 0; - else if (stride != 0) - { - /* Ensure that the type length is always positive, even in the - case where (for example in Fortran) we have a negative - stride. It is possible to have a single element array with a - negative stride in Fortran (this doesn't mean anything - special, it's still just a single element array) so do - consider that case when touching this code. */ - LONGEST element_count = std::abs (high_bound - low_bound + 1); - TYPE_LENGTH (result_type) - = ((std::abs (stride) * element_count) + 7) / 8; - } - else - TYPE_LENGTH (result_type) = - TYPE_LENGTH (element_type) * (high_bound - low_bound + 1); - } - else + if (!update_static_array_size (result_type)) { /* This type is dynamic and its length needs to be computed on demand. In the meantime, avoid leaving the TYPE_LENGTH @@ -1273,15 +1301,6 @@ create_array_type_with_stride (struct type *result_type, TYPE_LENGTH (result_type) = 0; } - TYPE_NFIELDS (result_type) = 1; - TYPE_FIELDS (result_type) = - (struct field *) TYPE_ZALLOC (result_type, sizeof (struct field)); - TYPE_INDEX_TYPE (result_type) = range_type; - if (byte_stride_prop != NULL) - add_dyn_prop (DYN_PROP_BYTE_STRIDE, *byte_stride_prop, result_type); - else if (bit_stride > 0) - TYPE_FIELD_BITSIZE (result_type, 0) = bit_stride; - /* TYPE_TARGET_STUB will take care of zero length arrays. */ if (TYPE_LENGTH (result_type) == 0) TYPE_TARGET_STUB (result_type) = 1; @@ -2873,20 +2892,9 @@ check_typedef (struct type *type) TYPE_LENGTH (type) = TYPE_LENGTH (target_type); TYPE_TARGET_STUB (type) = 0; } - else if (TYPE_CODE (type) == TYPE_CODE_ARRAY) - { - struct type *range_type = check_typedef (TYPE_INDEX_TYPE (type)); - if (has_static_range (TYPE_RANGE_DATA (range_type))) - { - ULONGEST len = 0; - LONGEST low_bound = TYPE_LOW_BOUND (range_type); - LONGEST high_bound = TYPE_HIGH_BOUND (range_type); - if (high_bound >= low_bound) - len = (high_bound - low_bound + 1) * TYPE_LENGTH (target_type); - TYPE_LENGTH (type) = len; - TYPE_TARGET_STUB (type) = 0; - } - } + else if (TYPE_CODE (type) == TYPE_CODE_ARRAY + && update_static_array_size (type)) + TYPE_TARGET_STUB (type) = 0; } type = make_qualified_type (type, instance_flags, NULL); -- 2.30.2