From 8e1d55a3dfe0d11fcc0921d97a80dc280a1af06b Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Thu, 14 Feb 2013 18:07:19 +0000 Subject: [PATCH] gdbserver: QTNotes, plug memory leak. The previous notes aren't being released before setting new ones. Tested on x86_64 Fedora 17. gdb/gdbserver/ 2013-02-14 Pedro Alves Plug memory leak. * tracepoint.c (cmd_qtnotes): Free TRACING_USER_NAME, TRACING_NOTES and TRACING_STOP_NOTE before clobbering. --- gdb/gdbserver/ChangeLog | 7 +++++++ gdb/gdbserver/tracepoint.c | 3 +++ 2 files changed, 10 insertions(+) diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 07bd1a8a7ad..3b2239fc866 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,10 @@ +2013-02-14 Pedro Alves + + Plug memory leak. + + * tracepoint.c (cmd_qtnotes): Free TRACING_USER_NAME, + TRACING_NOTES and TRACING_STOP_NOTE before clobbering. + 2013-02-14 Pedro Alves * tracepoint.c (cmd_qtdpsrc): Use savestring. diff --git a/gdb/gdbserver/tracepoint.c b/gdb/gdbserver/tracepoint.c index 0ffedaa1344..95c55adec3f 100644 --- a/gdb/gdbserver/tracepoint.c +++ b/gdb/gdbserver/tracepoint.c @@ -4042,6 +4042,7 @@ cmd_qtnotes (char *own_buf) user[nbytes] = '\0'; ++packet; /* skip the semicolon */ trace_debug ("User is '%s'", user); + xfree (tracing_user_name); tracing_user_name = user; } else if (strncmp ("notes:", packet, strlen ("notes:")) == 0) @@ -4055,6 +4056,7 @@ cmd_qtnotes (char *own_buf) notes[nbytes] = '\0'; ++packet; /* skip the semicolon */ trace_debug ("Notes is '%s'", notes); + xfree (tracing_notes); tracing_notes = notes; } else if (strncmp ("tstop:", packet, strlen ("tstop:")) == 0) @@ -4068,6 +4070,7 @@ cmd_qtnotes (char *own_buf) stopnote[nbytes] = '\0'; ++packet; /* skip the semicolon */ trace_debug ("tstop note is '%s'", stopnote); + xfree (tracing_stop_note); tracing_stop_note = stopnote; } else -- 2.30.2