From 8ec4028d4057da19708b4f4bce88ee16f96f322a Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Mon, 3 Feb 2020 14:28:18 -0500 Subject: [PATCH] panfrost: Avoid overlapping copy CID 1457486: Memory - corruptions (OVERLAPPING_COPY) Assigning "(*attr).extra_flags = (*attr).size = 0U" to "(*attr).stride", which have overlapping memory +locations. Coverity. Signed-off-by: Alyssa Rosenzweig Reviewed-by: Tomeu Vizoso Part-of: --- src/panfrost/encoder/pan_attributes.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/panfrost/encoder/pan_attributes.c b/src/panfrost/encoder/pan_attributes.c index d15ed9c1ea1..d4c8ab6e8ad 100644 --- a/src/panfrost/encoder/pan_attributes.c +++ b/src/panfrost/encoder/pan_attributes.c @@ -202,7 +202,9 @@ panfrost_instance_id( union mali_attr *attr) { attr->elements = MALI_ATTR_INSTANCEID; - attr->stride = attr->extra_flags = attr->size = 0; + attr->stride = 0; + attr->extra_flags = 0; + attr->size = 0; /* POT records have just a shift directly with an off-by-one for * unclear reasons. NPOT records have a magic divisor smushed into the -- 2.30.2