From 8f16b6ca77d55ee47e256070b1efe34f03d08f9a Mon Sep 17 00:00:00 2001 From: Maxim Ostapenko Date: Tue, 8 Nov 2016 22:09:33 +0000 Subject: [PATCH] asan_globals.cc (RegisterGlobal): Do not call CheckODRViolationViaPoisoning. libsanitizer/ * asan/asan_globals.cc (RegisterGlobal): Do not call CheckODRViolationViaPoisoning. (CheckODRViolationViaPoisoning): Remove. From-SVN: r241981 --- libsanitizer/ChangeLog | 6 ++++++ libsanitizer/asan/asan_globals.cc | 19 ------------------- 2 files changed, 6 insertions(+), 19 deletions(-) diff --git a/libsanitizer/ChangeLog b/libsanitizer/ChangeLog index 7881ac7da39..dad373eb967 100644 --- a/libsanitizer/ChangeLog +++ b/libsanitizer/ChangeLog @@ -1,3 +1,9 @@ +2016-11-09 Maxim Ostapenko + + * asan/asan_globals.cc (RegisterGlobal): Do not call + CheckODRViolationViaPoisoning. + (CheckODRViolationViaPoisoning): Remove. + 2016-11-09 Maxim Ostapenko * sanitizer_common/sanitizer_stacktrace.cc (GetCanonicFrame): Assume we diff --git a/libsanitizer/asan/asan_globals.cc b/libsanitizer/asan/asan_globals.cc index 007fce72be0..f2292926e6a 100644 --- a/libsanitizer/asan/asan_globals.cc +++ b/libsanitizer/asan/asan_globals.cc @@ -147,23 +147,6 @@ static void CheckODRViolationViaIndicator(const Global *g) { } } -// Check ODR violation for given global G by checking if it's already poisoned. -// We use this method in case compiler doesn't use private aliases for global -// variables. -static void CheckODRViolationViaPoisoning(const Global *g) { - if (__asan_region_is_poisoned(g->beg, g->size_with_redzone)) { - // This check may not be enough: if the first global is much larger - // the entire redzone of the second global may be within the first global. - for (ListOfGlobals *l = list_of_all_globals; l; l = l->next) { - if (g->beg == l->g->beg && - (flags()->detect_odr_violation >= 2 || g->size != l->g->size) && - !IsODRViolationSuppressed(g->name)) - ReportODRViolation(g, FindRegistrationSite(g), - l->g, FindRegistrationSite(l->g)); - } - } -} - // Clang provides two different ways for global variables protection: // it can poison the global itself or its private alias. In former // case we may poison same symbol multiple times, that can help us to @@ -211,8 +194,6 @@ static void RegisterGlobal(const Global *g) { // where two globals with the same name are defined in different modules. if (UseODRIndicator(g)) CheckODRViolationViaIndicator(g); - else - CheckODRViolationViaPoisoning(g); } if (CanPoisonMemory()) PoisonRedZones(*g); -- 2.30.2