From 8f8accb58078b1f249dc6865b8784a0a8e8881dd Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Wed, 27 Sep 2017 20:39:32 -0600 Subject: [PATCH] Remove cleanup from tilegx-tdep.c This removes a cleanup from tilegx-tdep.c, by using gdb::byte_vector. gdb/ChangeLog 2017-09-29 Tom Tromey * tilegx-tdep.c (tilegx_push_dummy_call): Use gdb::byte_vector. --- gdb/ChangeLog | 4 ++++ gdb/tilegx-tdep.c | 13 +++++-------- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 0e76e7f559d..23384613ee6 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2017-09-29 Tom Tromey + + * tilegx-tdep.c (tilegx_push_dummy_call): Use gdb::byte_vector. + 2017-09-29 Tom Tromey * utils.c (vfprintf_maybe_filtered): Use std::string. diff --git a/gdb/tilegx-tdep.c b/gdb/tilegx-tdep.c index b26622d05db..5291e10f60b 100644 --- a/gdb/tilegx-tdep.c +++ b/gdb/tilegx-tdep.c @@ -42,6 +42,7 @@ #include "tilegx-tdep.h" #include "opcode/tilegx.h" #include +#include "common/byte-vector.h" struct tilegx_frame_cache { @@ -328,21 +329,17 @@ tilegx_push_dummy_call (struct gdbarch *gdbarch, the stack, word aligned. */ for (j = nargs - 1; j >= i; j--) { - gdb_byte *val; - struct cleanup *back_to; const gdb_byte *contents = value_contents (args[j]); typelen = TYPE_LENGTH (value_enclosing_type (args[j])); slacklen = align_up (typelen, 8) - typelen; - val = (gdb_byte *) xmalloc (typelen + slacklen); - back_to = make_cleanup (xfree, val); - memcpy (val, contents, typelen); - memset (val + typelen, 0, slacklen); + gdb::byte_vector val (typelen + slacklen); + memcpy (val.data (), contents, typelen); + memset (val.data () + typelen, 0, slacklen); /* Now write data to the stack. The stack grows downwards. */ stack_dest -= typelen + slacklen; - write_memory (stack_dest, val, typelen + slacklen); - do_cleanups (back_to); + write_memory (stack_dest, val.data (), typelen + slacklen); } /* Add 16 bytes for linkage space to the stack. */ -- 2.30.2