From 8fb933841ff17d91231342f4b56f11bee6e08b09 Mon Sep 17 00:00:00 2001 From: Giacomo Travaglini Date: Mon, 17 Feb 2020 14:27:46 +0000 Subject: [PATCH] arch-arm: Fix ArmKVM build BaseInterrupts don't have a checkRaw method. This was breaking gem5 compilation on a Arm machine Change-Id: I8717b1bcf64ed14e8a0f63a9dcaca6041dbea4d3 Signed-off-by: Giacomo Travaglini Reviewed-by: Nikos Nikoleris Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/25431 Reviewed-by: Jason Lowe-Power Reviewed-by: Gabe Black Tested-by: kokoro --- src/arch/arm/kvm/arm_cpu.cc | 6 ++++-- src/arch/arm/kvm/base_cpu.cc | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/arch/arm/kvm/arm_cpu.cc b/src/arch/arm/kvm/arm_cpu.cc index 80576a25a..24f7be8b2 100644 --- a/src/arch/arm/kvm/arm_cpu.cc +++ b/src/arch/arm/kvm/arm_cpu.cc @@ -45,6 +45,7 @@ #include #include +#include "arch/arm/interrupts.hh" #include "arch/registers.hh" #include "cpu/kvm/base.hh" #include "debug/Kvm.hh" @@ -270,8 +271,9 @@ ArmKvmCPU::startup() Tick ArmKvmCPU::kvmRun(Tick ticks) { - bool simFIQ(interrupts[0]->checkRaw(INT_FIQ)); - bool simIRQ(interrupts[0]->checkRaw(INT_IRQ)); + auto interrupt = static_cast(interrupts[0]); + const bool simFIQ(interrupt->checkRaw(INT_FIQ)); + const bool simIRQ(interrupt->checkRaw(INT_IRQ)); if (fiqAsserted != simFIQ) { fiqAsserted = simFIQ; diff --git a/src/arch/arm/kvm/base_cpu.cc b/src/arch/arm/kvm/base_cpu.cc index 765965092..c99e853a3 100644 --- a/src/arch/arm/kvm/base_cpu.cc +++ b/src/arch/arm/kvm/base_cpu.cc @@ -41,6 +41,7 @@ #include +#include "arch/arm/interrupts.hh" #include "debug/KvmInt.hh" #include "params/BaseArmKvmCPU.hh" @@ -88,8 +89,9 @@ BaseArmKvmCPU::startup() Tick BaseArmKvmCPU::kvmRun(Tick ticks) { - const bool simFIQ(interrupts[0]->checkRaw(INT_FIQ)); - const bool simIRQ(interrupts[0]->checkRaw(INT_IRQ)); + auto interrupt = static_cast(interrupts[0]); + const bool simFIQ(interrupt->checkRaw(INT_FIQ)); + const bool simIRQ(interrupt->checkRaw(INT_IRQ)); if (!vm.hasKernelIRQChip()) { if (fiqAsserted != simFIQ) { -- 2.30.2