From 8fd18642e78858d454eac4581a07f00b9591d9c0 Mon Sep 17 00:00:00 2001 From: Topi Pohjolainen Date: Mon, 3 Jul 2017 14:23:35 +0300 Subject: [PATCH] i965/miptree: Set refcount before failing via _release() Otherwise one wraps uint to UINT_MAX via -1. Fixes: 3cf470f2b6c ("i965: Add isl based miptree creator") Reviewed-by: Emil Velikov Reviewed-by: Jason Ekstrand Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index 47475689f9c..5f60abb3de3 100644 --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c +++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c @@ -709,6 +709,8 @@ make_surface(struct brw_context *brw, GLenum target, mesa_format format, return NULL; } + mt->refcount = 1; + if (target == GL_TEXTURE_CUBE_MAP || target == GL_TEXTURE_CUBE_MAP_ARRAY) isl_usage_flags |= ISL_SURF_USAGE_CUBE_BIT; @@ -753,7 +755,6 @@ make_surface(struct brw_context *brw, GLenum target, mesa_format format, mt->last_level = last_level; mt->target = target; mt->format = format; - mt->refcount = 1; mt->aux_state = NULL; return mt; -- 2.30.2