From 902d61e3285aa88e635195a0f77541c44d1dfb2c Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Mon, 30 Jan 2023 15:46:15 -0500 Subject: [PATCH] gdb: fix dwarf2/cooked-index.c compilation on 32-bit systems MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The i386 builder shows: ../../binutils-gdb/gdb/dwarf2/cooked-index.c: In member function ‘void cooked_index_vector::dump(gdbarch*) const’: ../../binutils-gdb/gdb/dwarf2/cooked-index.c:492:40: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘std::__underlying_type_impl::type’ {aka ‘long long unsigned int’} [-Werror=format=] 492 | gdb_printf (" DIE offset: 0x%lx\n", | ~~^ | | | long unsigned int | %llx 493 | to_underlying (entry->die_offset)); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | std::__underlying_type_impl::type {aka long long unsigned int} The die_offset's underlying type is uint64, so use PRIx64 in the format string. Change-Id: Ibdde4c624ed1bb50eced9a514a4e37aec70a1323 --- gdb/dwarf2/cooked-index.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/dwarf2/cooked-index.c b/gdb/dwarf2/cooked-index.c index 9dbb844cade..82dc44dd74b 100644 --- a/gdb/dwarf2/cooked-index.c +++ b/gdb/dwarf2/cooked-index.c @@ -489,7 +489,7 @@ cooked_index_vector::dump (gdbarch *arch) const gdb_printf (" canonical: %s\n", entry->canonical); gdb_printf (" DWARF tag: %s\n", dwarf_tag_name (entry->tag)); gdb_printf (" flags: %s\n", to_string (entry->flags).c_str ()); - gdb_printf (" DIE offset: 0x%lx\n", + gdb_printf (" DIE offset: 0x%" PRIx64 "\n", to_underlying (entry->die_offset)); if (entry->parent_entry != nullptr) -- 2.30.2