From 90818558f0e8e50cd20f637775f072b5511edfd0 Mon Sep 17 00:00:00 2001 From: Eric Anholt Date: Wed, 12 Dec 2018 11:11:07 -0800 Subject: [PATCH] docs: Add an encouraging note about providing reviews and acks. Across several projects I've seen new contributors say "I wasn't sure if I should provide a review tag since I'm not really an expert in this area." Everyone I know already applies some implicit weighting to reviews from different people, so encourage participation. Reviewed-by: Dylan Baker Reviewed-by: Ian Romanick --- docs/submittingpatches.html | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html index d0b61a34099..61c6d1f8806 100644 --- a/docs/submittingpatches.html +++ b/docs/submittingpatches.html @@ -302,6 +302,14 @@ These Reviewed-by, Acked-by, and Tested-by tags should also be amended into commits in a MR before it is merged.

+

+Review by non-experts is encouraged. Understanding how someone else +goes about solving a problem is a great way to learn your way around +the project. The submitter is expected to evaluate whether they have +an appropriate amount of review feedback from people who also +understand the code before merging their patches. +

+

Nominating a commit for a stable branch

-- 2.30.2