From 914d6af8a875f472a919fd6619a0a7da7fd78c6d Mon Sep 17 00:00:00 2001 From: Jason Lowe-Power Date: Tue, 15 Sep 2020 17:59:51 -0700 Subject: [PATCH] configs: Add special case in MemConfig SimpleMemory doesn't implement a full MemCtrl interface. Thus, like the NVM and HMC memories, we need to add a special case to MemConfig.py. The --mem-type command line option now works for SimpleMemory and all of the DRAM interfaces (it does not work for the NVM interfaces, though). Issue-on: https://gem5.atlassian.net/browse/GEM5-777 Change-Id: I6d60649215be324bdd2a104b1976752f936c960e Signed-off-by: Jason Lowe-Power Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/34595 Reviewed-by: Daniel Carvalho Reviewed-by: Nikos Nikoleris Maintainer: Jason Lowe-Power Tested-by: kokoro --- configs/common/MemConfig.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configs/common/MemConfig.py b/configs/common/MemConfig.py index 941b381d4..8221f85f0 100644 --- a/configs/common/MemConfig.py +++ b/configs/common/MemConfig.py @@ -227,11 +227,15 @@ def config_mem(options, system): mem_ctrl = m5.objects.MemCtrl(min_writes_per_switch = 8, static_backend_latency = '4ns', static_frontend_latency = '4ns') + elif opt_mem_type == "SimpleMemory": + mem_ctrl = m5.objects.SimpleMemory() else: mem_ctrl = m5.objects.MemCtrl() # Hookup the controller to the interface and add to the list - mem_ctrl.dram = dram_intf + if opt_mem_type != "SimpleMemory": + mem_ctrl.dram = dram_intf + mem_ctrls.append(mem_ctrl) elif opt_nvm_type and (not opt_mem_type or range_iter % 2 == 0): -- 2.30.2