From 916cc3e231a34551bc9534943bff8e17e52931bf Mon Sep 17 00:00:00 2001 From: Rhys Perry Date: Mon, 27 Apr 2020 17:49:22 +0100 Subject: [PATCH] aco: make RegisterFile::block() take a regclass MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Rhys Perry Reviewed-by: Daniel Schürmann Part-of: --- src/amd/compiler/aco_register_allocation.cpp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/amd/compiler/aco_register_allocation.cpp b/src/amd/compiler/aco_register_allocation.cpp index 03c0c334cdf..02d4e9f8781 100644 --- a/src/amd/compiler/aco_register_allocation.cpp +++ b/src/amd/compiler/aco_register_allocation.cpp @@ -157,11 +157,11 @@ public: return false; } - void block(PhysReg start, unsigned num_bytes) { - if (start.byte() || num_bytes % 4) - fill_subdword(start, num_bytes, 0xFFFFFFFF); + void block(PhysReg start, RegClass rc) { + if (rc.is_subdword()) + fill_subdword(start, rc.bytes(), 0xFFFFFFFF); else - fill(start, num_bytes / 4, 0xFFFFFFFF); + fill(start, rc.size(), 0xFFFFFFFF); } bool is_blocked(PhysReg start) { @@ -570,7 +570,7 @@ bool get_regs_for_copies(ra_ctx& ctx, if (res.second) { /* mark the area as blocked */ - reg_file.block(res.first, var.rc.bytes()); + reg_file.block(res.first, var.rc); /* create parallelcopy pair (without definition id) */ Temp tmp = Temp(id, var.rc); @@ -657,7 +657,7 @@ bool get_regs_for_copies(ra_ctx& ctx, std::set> new_vars = collect_vars(ctx, reg_file, PhysReg{reg_lo}, size); /* mark the area as blocked */ - reg_file.block(PhysReg{reg_lo}, size * 4); + reg_file.block(PhysReg{reg_lo}, var.rc); if (!get_regs_for_copies(ctx, reg_file, parallelcopies, new_vars, lb, ub, instr, def_reg_lo, def_reg_hi)) return false; @@ -700,7 +700,7 @@ std::pair get_reg_impl(ra_ctx& ctx, instr->operands[j].physReg() < ub) { assert(instr->operands[j].isFixed()); assert(!reg_file.test(instr->operands[j].physReg(), instr->operands[j].bytes())); - reg_file.block(instr->operands[j].physReg(), instr->operands[j].bytes()); + reg_file.block(instr->operands[j].physReg(), instr->operands[j].regClass()); killed_ops += instr->operands[j].getTemp().size(); } } @@ -1934,7 +1934,7 @@ void register_allocation(Program *program, std::vector& live_out_per_bl } for (const Operand& op : instr->operands) { if (op.isTemp() && op.isFirstKill()) - register_file.block(op.physReg(), op.bytes()); + register_file.block(op.physReg(), op.regClass()); } handle_pseudo(ctx, register_file, pc.get()); @@ -1987,7 +1987,7 @@ void register_allocation(Program *program, std::vector& live_out_per_bl register_file.clear(def); for (const Operand& op : instr->operands) { if (op.isTemp() && op.isFirstKill()) - register_file.block(op.physReg(), op.bytes()); + register_file.block(op.physReg(), op.regClass()); } Temp tmp = {program->allocateId(), can_sgpr ? s1 : v1}; ctx.assignments.emplace_back(); -- 2.30.2