From 9173459b950218cff72d7f31dea34a25955619c4 Mon Sep 17 00:00:00 2001 From: Kenneth Graunke Date: Sat, 7 Sep 2019 23:43:05 -0700 Subject: [PATCH] iris: Ignore line stipple information if it's disabled The line stipple pattern and factor only matter if line stippling is actually enabled. Otherwise, we can safely ignore it. PBO upload may give us zero for line stipple information, while normal drawing tends to give us an actual stipple pattern such as 0xffff. This was causing us to flag IRIS_DIRTY_LINE_STIPPLE way too often, leading to useless 3DSTATE_LINE_STIPPLE commands, which are non-pipelined and thus very expensive. Improves performance in Manhattan 3.0 on Skylake GT4e by 0.149261% +/- 0.0380796% (n=210). On an Icelake 8x8 with the GPU frequency locked at 700Mhz, improves by 0.423756% +/- 0.222843% (n=3). --- src/gallium/drivers/iris/iris_state.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/iris/iris_state.c b/src/gallium/drivers/iris/iris_state.c index c63732c4acc..315b0133420 100644 --- a/src/gallium/drivers/iris/iris_state.c +++ b/src/gallium/drivers/iris/iris_state.c @@ -1419,9 +1419,11 @@ iris_create_rasterizer_state(struct pipe_context *ctx, const unsigned line_stipple_factor = state->line_stipple_factor + 1; iris_pack_command(GENX(3DSTATE_LINE_STIPPLE), cso->line_stipple, line) { - line.LineStipplePattern = state->line_stipple_pattern; - line.LineStippleInverseRepeatCount = 1.0f / line_stipple_factor; - line.LineStippleRepeatCount = line_stipple_factor; + if (state->line_stipple_enable) { + line.LineStipplePattern = state->line_stipple_pattern; + line.LineStippleInverseRepeatCount = 1.0f / line_stipple_factor; + line.LineStippleRepeatCount = line_stipple_factor; + } } return cso; -- 2.30.2