From 93497bf9ab13a3d2aa06ff329155beca23e323fa Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Fri, 26 May 2023 12:44:52 +0200 Subject: [PATCH] x86: fix disassembler build after 1a3b4f90bc5f In commit 1a3b4f90bc5f ("x86: convert two pointers to (indexing) integers") I neglected the fact that compilers may warn about comparing ptrdiff_t (signed long) with size_t (unsigned long) values. Since just before we've checked that the value is positive, simply add a cast (despite my dislike for casts). --- opcodes/i386-dis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/opcodes/i386-dis.c b/opcodes/i386-dis.c index 6f75abf57f3..6161bf72459 100644 --- a/opcodes/i386-dis.c +++ b/opcodes/i386-dis.c @@ -300,7 +300,7 @@ fetch_code (struct disassemble_info *info, const uint8_t *until) if (needed <= 0) return true; - if (priv->fetched + needed <= ARRAY_SIZE (priv->the_buffer)) + if (priv->fetched + (size_t) needed <= ARRAY_SIZE (priv->the_buffer)) status = (*info->read_memory_func) (start, fetch_end, needed, info); if (status != 0) { -- 2.30.2