From 93be4158aed9accab06e3df2d8c526d3312bfff8 Mon Sep 17 00:00:00 2001 From: Francisco Jerez Date: Fri, 11 Mar 2016 15:27:22 -0800 Subject: [PATCH] i965/fs: Add missing analysis invalidation in fixup_3src_null_dest(). Bug found by the liveness analysis validation pass that will be introduced in a later commit. fixup_3src_null_dest() was allocating registers which makes the cached liveness analysis calculation incomplete, so it must be invalidated. Cc: mesa-stable@lists.freedesktop.org Reviewed-by: Matt Turner --- src/mesa/drivers/dri/i965/brw_fs.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 42bc5e2a027..86d2bd92726 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp @@ -5190,12 +5190,18 @@ fs_visitor::optimize() void fs_visitor::fixup_3src_null_dest() { + bool progress = false; + foreach_block_and_inst_safe (block, fs_inst, inst, cfg) { if (inst->is_3src() && inst->dst.is_null()) { inst->dst = fs_reg(VGRF, alloc.allocate(dispatch_width / 8), inst->dst.type); + progress = true; } } + + if (progress) + invalidate_live_intervals(); } void -- 2.30.2