From 93fb460faded99c640ff0d7273611932a9ebc46c Mon Sep 17 00:00:00 2001 From: Gabe Black Date: Thu, 1 Dec 2011 00:17:14 -0500 Subject: [PATCH] X86: Fix a bad segmentation check for the stack segment. --HG-- extra : rebase_source : 755f4f6eae52f88ed516a1f1ac9e2565725d89c1 --- src/arch/x86/isa/microops/regop.isa | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/arch/x86/isa/microops/regop.isa b/src/arch/x86/isa/microops/regop.isa index a6e0564ba..bc139a609 100644 --- a/src/arch/x86/isa/microops/regop.isa +++ b/src/arch/x86/isa/microops/regop.isa @@ -1335,16 +1335,15 @@ let {{ if (selector.si || selector.ti) { if (!desc.p) { fault = new StackFault(selector); - } - } else { - if ((m5reg.submode != SixtyFourBitMode || - m5reg.cpl == 3) || - !(desc.s == 1 && - desc.type.codeOrData == 0 && desc.type.w) || + } else if (!(desc.s == 1 && desc.type.codeOrData == 0 && + desc.type.w) || (desc.dpl != m5reg.cpl) || (selector.rpl != m5reg.cpl)) { fault = new GeneralProtection(selector); } + } else if (m5reg.submode != SixtyFourBitMode || + m5reg.cpl == 3) { + fault = new GeneralProtection(selector); } break; case SegIretCheck: -- 2.30.2