From 9405e15f51bfafa1afcc9f32a00da98f2de42877 Mon Sep 17 00:00:00 2001 From: Roland Scheidegger Date: Sat, 30 Aug 2014 04:58:58 +0200 Subject: [PATCH 1/1] gallivm: (trivial) fix min / max variable names Calling the variable min when it's really max and vice versa seems a bit confusing. Reviewed-by: Brian Paul Reviewed-by: Jose Fonseca --- src/gallium/auxiliary/gallivm/lp_bld_arit.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_arit.c b/src/gallium/auxiliary/gallivm/lp_bld_arit.c index 82eebfba241..8f3b5687752 100644 --- a/src/gallium/auxiliary/gallivm/lp_bld_arit.c +++ b/src/gallium/auxiliary/gallivm/lp_bld_arit.c @@ -205,17 +205,17 @@ lp_build_min_simple(struct lp_build_context *bld, nan_behavior != GALLIVM_NAN_BEHAVIOR_UNDEFINED && nan_behavior != GALLIVM_NAN_RETURN_OTHER_SECOND_NONNAN && nan_behavior != GALLIVM_NAN_RETURN_NAN_FIRST_NONNAN) { - LLVMValueRef isnan, max; - max = lp_build_intrinsic_binary_anylength(bld->gallivm, intrinsic, + LLVMValueRef isnan, min; + min = lp_build_intrinsic_binary_anylength(bld->gallivm, intrinsic, type, intr_size, a, b); if (nan_behavior == GALLIVM_NAN_RETURN_OTHER) { isnan = lp_build_isnan(bld, b); - return lp_build_select(bld, isnan, a, max); + return lp_build_select(bld, isnan, a, min); } else { assert(nan_behavior == GALLIVM_NAN_RETURN_NAN); isnan = lp_build_isnan(bld, a); - return lp_build_select(bld, isnan, a, max); + return lp_build_select(bld, isnan, a, min); } } else { return lp_build_intrinsic_binary_anylength(bld->gallivm, intrinsic, @@ -381,17 +381,17 @@ lp_build_max_simple(struct lp_build_context *bld, nan_behavior != GALLIVM_NAN_BEHAVIOR_UNDEFINED && nan_behavior != GALLIVM_NAN_RETURN_OTHER_SECOND_NONNAN && nan_behavior != GALLIVM_NAN_RETURN_NAN_FIRST_NONNAN) { - LLVMValueRef isnan, min; - min = lp_build_intrinsic_binary_anylength(bld->gallivm, intrinsic, + LLVMValueRef isnan, max; + max = lp_build_intrinsic_binary_anylength(bld->gallivm, intrinsic, type, intr_size, a, b); if (nan_behavior == GALLIVM_NAN_RETURN_OTHER) { isnan = lp_build_isnan(bld, b); - return lp_build_select(bld, isnan, a, min); + return lp_build_select(bld, isnan, a, max); } else { assert(nan_behavior == GALLIVM_NAN_RETURN_NAN); isnan = lp_build_isnan(bld, a); - return lp_build_select(bld, isnan, a, min); + return lp_build_select(bld, isnan, a, max); } } else { return lp_build_intrinsic_binary_anylength(bld->gallivm, intrinsic, -- 2.30.2