From 947470d10ba5ab11a75f0e19e124b189ff3fd8b2 Mon Sep 17 00:00:00 2001 From: James Legg Date: Wed, 6 Dec 2017 11:55:14 +0000 Subject: [PATCH] nir/opcodes: Fix constant-folding of bitfield_insert Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104119 CC: CC: Samuel Pitoiset Reviewed-by: Matt Turner --- src/compiler/nir/nir_opcodes.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_opcodes.py b/src/compiler/nir/nir_opcodes.py index ac7333fe781..278562b2bd1 100644 --- a/src/compiler/nir/nir_opcodes.py +++ b/src/compiler/nir/nir_opcodes.py @@ -724,12 +724,12 @@ opcode("bitfield_insert", 0, tuint32, [0, 0, 0, 0], unsigned base = src0, insert = src1; int offset = src2, bits = src3; if (bits == 0) { - dst = 0; + dst = base; } else if (offset < 0 || bits < 0 || bits + offset > 32) { dst = 0; } else { unsigned mask = ((1ull << bits) - 1) << offset; - dst = (base & ~mask) | ((insert << bits) & mask); + dst = (base & ~mask) | ((insert << offset) & mask); } """) -- 2.30.2