From 94e6263c0b0ebb81c511452c7844394802bf37b9 Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Fri, 1 May 2020 14:12:06 -0400 Subject: [PATCH] pan/bi: Abort on unknown op packing We're stable enough this is better than just nop'ing it out. Signed-off-by: Alyssa Rosenzweig Part-of: --- src/panfrost/bifrost/bi_pack.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/panfrost/bifrost/bi_pack.c b/src/panfrost/bifrost/bi_pack.c index 6f1b6dc7c53..f6bdc1ebc87 100644 --- a/src/panfrost/bifrost/bi_pack.c +++ b/src/panfrost/bifrost/bi_pack.c @@ -1163,13 +1163,13 @@ bi_pack_fma(bi_clause *clause, bi_bundle bundle, struct bi_registers *regs) case BI_FREXP: return bi_pack_fma_frexp(bundle.fma, regs); case BI_ISUB: - return BIFROST_FMA_NOP; + unreachable("Packing todo"); case BI_MINMAX: return bi_pack_fma_addmin(bundle.fma, regs); case BI_MOV: return bi_pack_fma_1src(bundle.fma, regs, BIFROST_FMA_OP_MOV); case BI_SHIFT: - return BIFROST_FMA_NOP; + unreachable("Packing todo"); case BI_SELECT: return bi_pack_fma_select(bundle.fma, regs); case BI_ROUND: @@ -1486,18 +1486,18 @@ bi_pack_add(bi_clause *clause, bi_bundle bundle, struct bi_registers *regs) return bi_pack_add_atest(clause, bundle.add, regs); case BI_BRANCH: case BI_CMP: - return BIFROST_ADD_NOP; + unreachable("Packing todo"); case BI_BLEND: return bi_pack_add_blend(clause, bundle.add, regs); case BI_BITWISE: - return BIFROST_ADD_NOP; + unreachable("Packing todo"); case BI_CONVERT: return bi_pack_convert(bundle.add, regs, false); case BI_DISCARD: case BI_FREXP: case BI_ISUB: case BI_LOAD: - return BIFROST_ADD_NOP; + unreachable("Packing todo"); case BI_LOAD_ATTR: return bi_pack_add_ld_attr(clause, bundle.add, regs); case BI_LOAD_UNIFORM: @@ -1511,7 +1511,7 @@ bi_pack_add(bi_clause *clause, bi_bundle bundle, struct bi_registers *regs) case BI_MOV: case BI_SHIFT: case BI_STORE: - return BIFROST_ADD_NOP; + unreachable("Packing todo"); case BI_STORE_VAR: return bi_pack_add_st_vary(clause, bundle.add, regs); case BI_SPECIAL: @@ -1526,7 +1526,7 @@ bi_pack_add(bi_clause *clause, bi_bundle bundle, struct bi_registers *regs) else unreachable("Unknown tex type"); case BI_ROUND: - return BIFROST_ADD_NOP; + unreachable("Packing todo"); default: unreachable("Cannot encode class as ADD"); } -- 2.30.2