From 94f54d47ca0a7c629c4f950f139c06c959a765f6 Mon Sep 17 00:00:00 2001 From: Jonathan Wakely Date: Mon, 22 Aug 2016 17:47:34 +0100 Subject: [PATCH] Add noexcept to std::function swap PR libstdc++/77322 * doc/xml/manual/intro.xml: Document DR 2062 change. * include/std/functional (function::swap): Add noexcept. (swap(function + + PR libstdc++/77322 + * doc/xml/manual/intro.xml: Document DR 2062 change. + * include/std/functional (function::swap): Add noexcept. + (swap(function * testsuite/21_strings/basic_string/pthread18185.cc: Use -pthread for diff --git a/libstdc++-v3/doc/xml/manual/intro.xml b/libstdc++-v3/doc/xml/manual/intro.xml index a5e0a3bed01..ea4d1c52096 100644 --- a/libstdc++-v3/doc/xml/manual/intro.xml +++ b/libstdc++-v3/doc/xml/manual/intro.xml @@ -850,6 +850,12 @@ requirements of the license of GCC. Add additional overloads. + 2062: + 2062. Effect contradictions w/o no-throw guarantee of std::function swaps + + Add noexcept to swap functions. + + 2063: Contradictory requirements for string move assignment diff --git a/libstdc++-v3/include/std/functional b/libstdc++-v3/include/std/functional index 87d1c17d166..05d4282c8bd 100644 --- a/libstdc++-v3/include/std/functional +++ b/libstdc++-v3/include/std/functional @@ -1922,7 +1922,7 @@ _GLIBCXX_MEM_FN_TRAITS(&&, false_type, true_type) * Swap the targets of @c this function object and @a __f. This * function will not throw an %exception. */ - void swap(function& __x) + void swap(function& __x) noexcept { std::swap(_M_functor, __x._M_functor); std::swap(_M_manager, __x._M_manager); @@ -2124,9 +2124,11 @@ _GLIBCXX_MEM_FN_TRAITS(&&, false_type, true_type) * * This function will not throw an %exception. */ + // _GLIBCXX_RESOLVE_LIB_DEFECTS + // 2062. Effect contradictions w/o no-throw guarantee of std::function swaps template inline void - swap(function<_Res(_Args...)>& __x, function<_Res(_Args...)>& __y) + swap(function<_Res(_Args...)>& __x, function<_Res(_Args...)>& __y) noexcept { __x.swap(__y); } diff --git a/libstdc++-v3/testsuite/20_util/function/77322.cc b/libstdc++-v3/testsuite/20_util/function/77322.cc new file mode 100644 index 00000000000..67813d4e050 --- /dev/null +++ b/libstdc++-v3/testsuite/20_util/function/77322.cc @@ -0,0 +1,25 @@ +// Copyright (C) 2016 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// . + +// { dg-do compile { target c++11 } } + +#include + +// PR libstdc++/77322 +std::function f, g; +static_assert( noexcept(f.swap(g)), "member swap is noexcept" ); +static_assert( noexcept(swap(f, g)), "non-member swap is noexcept" ); -- 2.30.2