From 95ad161fe933b01986b426c47f019d58900d62a2 Mon Sep 17 00:00:00 2001 From: Tomi Valkeinen Date: Fri, 6 Aug 2021 15:50:46 +0300 Subject: [PATCH] package/kmsxx: remove erroneous use of static-libc option Currently, for a static-only build, we pass -Dstatic-libc=true. The reason for that was not recorded when the package was converted to meson. The -Dstatic-libc=true option, despite its name, is not about linking statically against libc, but against libgcc and libstdc++. In Buildroot, we forcibly pass -static when calling the compiler and linker, so everything is already linked statically. For a shared build, -Dstatic-libc=false has no effect at all. Drop this option altogether, as it is not needed, and is confusing. Signed-off-by: Tomi Valkeinen [yann.morin.1998@free.fr: expand commit log] Signed-off-by: Yann E. MORIN --- package/kmsxx/kmsxx.mk | 6 ------ 1 file changed, 6 deletions(-) diff --git a/package/kmsxx/kmsxx.mk b/package/kmsxx/kmsxx.mk index fd40ff8e73..871ecaf85c 100644 --- a/package/kmsxx/kmsxx.mk +++ b/package/kmsxx/kmsxx.mk @@ -17,12 +17,6 @@ KMSXX_CONF_OPTS = \ -Duse-system-fmt=true \ -Duse-system-pybind11=true -ifeq ($(BR2_STATIC_LIBS),y) -KMSXX_CONF_OPTS += -Dstatic-libc=true -else -KMSXX_CONF_OPTS += -Dstatic-libc=false -endif - ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y) KMSXX_CXXFLAGS += $(TARGET_CXXFLAGS) -O0 endif -- 2.30.2