From 95b3d0fda31a3ce11a84742374bd1ffaad57f6e2 Mon Sep 17 00:00:00 2001 From: Jonathan Wakely Date: Wed, 12 Jun 2019 21:16:03 +0100 Subject: [PATCH] Fix incorrect __cpp_lib_parallel_algorithm macro definitions * include/std/algorithm (__cpp_lib_parallel_algorithm): Fix value. * include/std/memory (__cpp_lib_parallel_algorithm): Likewise. * include/std/numeric (__cpp_lib_parallel_algorithm): Likewise. * testsuite/25_algorithms/pstl/feature_test.cc: New test. From-SVN: r272216 --- libstdc++-v3/ChangeLog | 5 ++ libstdc++-v3/include/std/algorithm | 2 +- libstdc++-v3/include/std/memory | 2 +- libstdc++-v3/include/std/numeric | 2 +- .../25_algorithms/pstl/feature_test.cc | 50 +++++++++++++++++++ 5 files changed, 58 insertions(+), 3 deletions(-) create mode 100644 libstdc++-v3/testsuite/25_algorithms/pstl/feature_test.cc diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog index 8895dca06de..4b5156bc229 100644 --- a/libstdc++-v3/ChangeLog +++ b/libstdc++-v3/ChangeLog @@ -1,5 +1,10 @@ 2019-06-12 Jonathan Wakely + * include/std/algorithm (__cpp_lib_parallel_algorithm): Fix value. + * include/std/memory (__cpp_lib_parallel_algorithm): Likewise. + * include/std/numeric (__cpp_lib_parallel_algorithm): Likewise. + * testsuite/25_algorithms/pstl/feature_test.cc: New test. + * include/std/variant (get, get, get_if, get_if) (variant::emplace): Change static_assert messages from "should be" to "must be". diff --git a/libstdc++-v3/include/std/algorithm b/libstdc++-v3/include/std/algorithm index 18182965fb1..124342c63f0 100644 --- a/libstdc++-v3/include/std/algorithm +++ b/libstdc++-v3/include/std/algorithm @@ -73,7 +73,7 @@ # endif // Feature test macro for parallel algorithms -# define __cpp_lib_parallel_algorithm 201703L +# define __cpp_lib_parallel_algorithm 201603L #endif // C++17 #ifdef _GLIBCXX_PARALLEL diff --git a/libstdc++-v3/include/std/memory b/libstdc++-v3/include/std/memory index 1fb4a5f956c..3660f4d86de 100644 --- a/libstdc++-v3/include/std/memory +++ b/libstdc++-v3/include/std/memory @@ -407,7 +407,7 @@ _GLIBCXX_END_NAMESPACE_VERSION # endif // Feature test macro for parallel algorithms -# define __cpp_lib_parallel_algorithm 201703L +# define __cpp_lib_parallel_algorithm 201603L #endif // C++17 #endif /* _GLIBCXX_MEMORY */ diff --git a/libstdc++-v3/include/std/numeric b/libstdc++-v3/include/std/numeric index def1debf754..01e3ae8e35d 100644 --- a/libstdc++-v3/include/std/numeric +++ b/libstdc++-v3/include/std/numeric @@ -216,7 +216,7 @@ _GLIBCXX_END_NAMESPACE_VERSION # endif // Feature test macro for parallel algorithms -# define __cpp_lib_parallel_algorithm 201703L +# define __cpp_lib_parallel_algorithm 201603L #endif // C++17 #endif /* _GLIBCXX_NUMERIC */ diff --git a/libstdc++-v3/testsuite/25_algorithms/pstl/feature_test.cc b/libstdc++-v3/testsuite/25_algorithms/pstl/feature_test.cc new file mode 100644 index 00000000000..e2ae11b5438 --- /dev/null +++ b/libstdc++-v3/testsuite/25_algorithms/pstl/feature_test.cc @@ -0,0 +1,50 @@ +// Copyright (C) 2019 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// . + +// { dg-options "-std=gnu++17" } +// { dg-do preprocess { target c++17 } } + +#include +#ifndef __cpp_lib_parallel_algorithm +# error "Feature-test macro for parallel algorithms missing" +#elif __cpp_lib_parallel_algorithm != 201603L +# error "Feature-test macro for parallel algorithms has wrong value in " +#endif + +#include +#if __cpp_lib_parallel_algorithm != 201603L +# error "Feature-test macro for parallel algorithms has wrong value in " +#endif + +#include +#if __cpp_lib_parallel_algorithm != 201603L +# error "Feature-test macro for parallel algorithms has wrong value in " +#endif + +// The N4810 draft does not require the macro to be defined in . +#include +#if __cpp_lib_parallel_algorithm != 201603L +# error "Feature-test macro for parallel algorithms has wrong value in " +#endif + +// The N4810 draft does not require the macro to be defined in . +// Include this last, because it will trigger the inclusion of TBB headers, +// which then include , so we need to have already checked . +#include +#if __cpp_lib_parallel_algorithm != 201603L +# error "Feature-test macro for parallel algorithms has wrong value in " +#endif -- 2.30.2