From 95bd0ad351fe03450f28699f80434539f3764438 Mon Sep 17 00:00:00 2001 From: Thomas Petazzoni Date: Tue, 21 Jul 2015 17:36:07 +0200 Subject: [PATCH] fs: build host-mkpasswd when BR2_ROOTFS_USERS_TABLES is used The code in fs/common.mk properly triggers the build of host-mkpasswd when at least one package specifies a _USERS variable. However, when no selected package specifies a _USERS variable but the user uses a custom users table through BR2_ROOTFS_USERS_TABLES, then we forget to build host-mkpasswd, leading to build failures if you don't have mkpasswd installed in your machine. This commit fixes that by taking into account both the package users table and the custom users table when deciding to depend or not on host-mkpasswd. Reported-by: Auke Willem Oosterhoff Cc: Auke Willem Oosterhoff Cc: Yann E. MORIN Signed-off-by: Thomas Petazzoni Acked-by: "Yann E. MORIN" --- fs/common.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/common.mk b/fs/common.mk index 4387d069a1..ad1bcf3034 100644 --- a/fs/common.mk +++ b/fs/common.mk @@ -41,7 +41,7 @@ define ROOTFS_TARGET_INTERNAL # extra deps ROOTFS_$(2)_DEPENDENCIES += host-fakeroot host-makedevs \ - $$(if $$(PACKAGES_USERS),host-mkpasswd) + $$(if $$(PACKAGES_USERS)$$(ROOTFS_USERS_TABLES),host-mkpasswd) ifeq ($$(BR2_TARGET_ROOTFS_$(2)_GZIP),y) ROOTFS_$(2)_COMPRESS_EXT = .gz -- 2.30.2