From 966a455bb912cc9fd22580c6cf9b74e27faa4491 Mon Sep 17 00:00:00 2001 From: Samuel Pitoiset Date: Tue, 27 Aug 2019 11:35:00 +0200 Subject: [PATCH] nir: do not assume that the result of fexp2(a) is always an integral It's only correct when 'a' is an integral greater or equal to 0. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111493 Fixes: 5544b2cbbd2 ("nir/algebraic: Use value range analysis to eliminate useless unary ops") Signed-off-by: Samuel Pitoiset Reviewed-by: Ian Romanick --- src/compiler/nir/nir_range_analysis.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/nir/nir_range_analysis.c b/src/compiler/nir/nir_range_analysis.c index a313087e056..6fec5fcd7ab 100644 --- a/src/compiler/nir/nir_range_analysis.c +++ b/src/compiler/nir/nir_range_analysis.c @@ -580,6 +580,7 @@ analyze_expression(const nir_alu_instr *instr, unsigned src, ASSERT_UNION_OF_DISJOINT_MATCHES_UNKNOWN_1_SOURCE(table); ASSERT_UNION_OF_EQ_AND_STRICT_INEQ_MATCHES_NONSTRICT_1_SOURCE(table); + r.is_integral = r.is_integral && is_not_negative(r.range); r.range = table[r.range]; break; } -- 2.30.2