From 96c4f946a8c8d53141189852c0ba28c45366830b Mon Sep 17 00:00:00 2001 From: Yao Qi Date: Wed, 6 Aug 2014 14:02:35 +0800 Subject: [PATCH] Replace 0 with TARGET_XFER_EOF in to_xfer_partial I run splint in gdb source and get the following warnings: ../../../git/gdb/corelow.c:740: Return value type int does not match declared type enum target_xfer_status: 0 'TARGET_XFER_EOF' (enum target_xfer_status) is expected to be returned, but 0 is returned. This patch is to replace 0 with TARGET_XFER_EOF in the implementations of to_xfer_partial. gdb: 2014-08-07 Yao Qi * corelow.c (core_xfer_partial): Replace 0 with TARGET_XFER_EOF. * remote-m32r-sdi.c (m32r_xfer_memory): Likewise. * remote.c (remote_read_bytes): Likewise. --- gdb/ChangeLog | 6 ++++++ gdb/corelow.c | 2 +- gdb/remote-m32r-sdi.c | 6 +++--- gdb/remote.c | 2 +- 4 files changed, 11 insertions(+), 5 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 68d1db9719f..93bfc721b90 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2014-08-07 Yao Qi + + * corelow.c (core_xfer_partial): Replace 0 with TARGET_XFER_EOF. + * remote-m32r-sdi.c (m32r_xfer_memory): Likewise. + * remote.c (remote_read_bytes): Likewise. + 2014-08-07 Yao Qi * dwarf2read.c (struct dwarf2_per_cu_data) : Tweak comments. diff --git a/gdb/corelow.c b/gdb/corelow.c index ff4d7338357..ecd99f61ceb 100644 --- a/gdb/corelow.c +++ b/gdb/corelow.c @@ -734,7 +734,7 @@ core_xfer_partial (struct target_ops *ops, enum target_object object, size = bfd_section_size (core_bfd, section); if (offset >= size) - return 0; + return TARGET_XFER_EOF; size -= offset; if (size > len) size = len; diff --git a/gdb/remote-m32r-sdi.c b/gdb/remote-m32r-sdi.c index 5443fe0a223..3d6b0c679fd 100644 --- a/gdb/remote-m32r-sdi.c +++ b/gdb/remote-m32r-sdi.c @@ -1080,7 +1080,7 @@ m32r_xfer_memory (gdb_byte *readbuf, const gdb_byte *writebuf, if (remote_debug) fprintf_unfiltered (gdb_stdlog, "m32r_xfer_memory() failed\n"); - return 0; + return TARGET_XFER_EOF; } ret = send_data (writebuf, len); } @@ -1094,7 +1094,7 @@ m32r_xfer_memory (gdb_byte *readbuf, const gdb_byte *writebuf, { if (remote_debug) fprintf_unfiltered (gdb_stdlog, "m32r_xfer_memory() failed\n"); - return 0; + return TARGET_XFER_EOF; } c = serial_readchar (sdi_desc, SDI_TIMEOUT); @@ -1102,7 +1102,7 @@ m32r_xfer_memory (gdb_byte *readbuf, const gdb_byte *writebuf, { if (remote_debug) fprintf_unfiltered (gdb_stdlog, "m32r_xfer_memory() failed\n"); - return 0; + return TARGET_XFER_EOF; } ret = recv_data (readbuf, len); diff --git a/gdb/remote.c b/gdb/remote.c index 8decd08536a..473bb724a20 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -6823,7 +6823,7 @@ remote_read_bytes (struct target_ops *ops, CORE_ADDR memaddr, gdb_byte *myaddr, ULONGEST len, ULONGEST *xfered_len) { if (len == 0) - return 0; + return TARGET_XFER_EOF; if (get_traceframe_number () != -1) { -- 2.30.2