From 96d493066dbfe6581b2647c36c351fac201da48b Mon Sep 17 00:00:00 2001 From: Doug Kwan Date: Thu, 4 Jun 2009 01:31:01 +0000 Subject: [PATCH] 2009-06-03 Doug Kwan * arm.cc (utils::sign_extend): Reverse test in gold_assert. (utils::has_overflow): Same. --- gold/ChangeLog | 5 +++++ gold/arm.cc | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gold/ChangeLog b/gold/ChangeLog index 7408ac61a62..8f42e6ae7bc 100644 --- a/gold/ChangeLog +++ b/gold/ChangeLog @@ -1,3 +1,8 @@ +2009-06-03 Doug Kwan + + * arm.cc (utils::sign_extend): Reverse test in gold_assert. + (utils::has_overflow): Same. + 2009-06-03 Ian Lance Taylor * layout.cc (Layout::section_name_mapping): New array, replacing diff --git a/gold/arm.cc b/gold/arm.cc index 5165a5220d5..76538de789d 100644 --- a/gold/arm.cc +++ b/gold/arm.cc @@ -97,7 +97,7 @@ namespace utils static inline int32_t sign_extend(uint32_t bits) { - gold_assert(no_bits < 1 || no_bits > 32); + gold_assert(no_bits >= 0 && no_bits <= 32); if (no_bits == 32) return static_cast(bits); uint32_t mask = (~((uint32_t) 0)) >> (32 - no_bits); @@ -112,7 +112,7 @@ namespace utils static inline bool has_overflow(uint32_t bits) { - gold_assert(no_bits < 1 || no_bits > 32); + gold_assert(no_bits >= 0 && no_bits <= 32); if (no_bits == 32) return false; int32_t max = (1 << (no_bits - 1)) - 1; -- 2.30.2