From 9734a586671fa95a06a2e10323c14d0157805057 Mon Sep 17 00:00:00 2001 From: Andrew Burgess Date: Thu, 27 Dec 2018 11:52:53 +0000 Subject: [PATCH] gdb/h8300: Use default gdbarch methods where possible Make use of the default gdbarch methods for gdbarch_dummy_id, gdbarch_unwind_pc, and gdbarch_unwind_sp where possible. I have not tested this change but, by inspecting the code, I believe the default methods are equivalent to the code being deleted. gdb/ChangeLog: * gdb/h8300-tdep.c (h8300_unwind_pc): Delete. (h8300_unwind_sp): Delete. (h8300_dummy_id): Delete. (h8300_gdbarch_init): Don't register deleted functions with gdbarch. --- gdb/ChangeLog | 8 ++++++++ gdb/h8300-tdep.c | 22 ---------------------- 2 files changed, 8 insertions(+), 22 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index ba877061d78..a4a1f219833 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,11 @@ +2019-02-27 Andrew Burgess + + * gdb/h8300-tdep.c (h8300_unwind_pc): Delete. + (h8300_unwind_sp): Delete. + (h8300_dummy_id): Delete. + (h8300_gdbarch_init): Don't register deleted functions with + gdbarch. + 2019-02-27 Andrew Burgess * gdb/ft32-tdep.c (ft32_dummy_id): Delete. diff --git a/gdb/h8300-tdep.c b/gdb/h8300-tdep.c index f0db416714c..b41a0b6c260 100644 --- a/gdb/h8300-tdep.c +++ b/gdb/h8300-tdep.c @@ -92,25 +92,6 @@ static int is_h8300_normal_mode (struct gdbarch *gdbarch); && !is_h8300_normal_mode (gdbarch)) \ ? h8300h_reg_size : h8300_reg_size) -static CORE_ADDR -h8300_unwind_pc (struct gdbarch *gdbarch, struct frame_info *next_frame) -{ - return frame_unwind_register_unsigned (next_frame, E_PC_REGNUM); -} - -static CORE_ADDR -h8300_unwind_sp (struct gdbarch *gdbarch, struct frame_info *next_frame) -{ - return frame_unwind_register_unsigned (next_frame, E_SP_REGNUM); -} - -static struct frame_id -h8300_dummy_id (struct gdbarch *gdbarch, struct frame_info *this_frame) -{ - CORE_ADDR sp = get_frame_register_unsigned (this_frame, E_SP_REGNUM); - return frame_id_build (sp, get_frame_pc (this_frame)); -} - /* Normal frames. */ /* Allocate and initialize a frame cache. */ @@ -1349,9 +1330,6 @@ h8300_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) set_gdbarch_skip_prologue (gdbarch, h8300_skip_prologue); /* Frame unwinder. */ - set_gdbarch_unwind_pc (gdbarch, h8300_unwind_pc); - set_gdbarch_unwind_sp (gdbarch, h8300_unwind_sp); - set_gdbarch_dummy_id (gdbarch, h8300_dummy_id); frame_base_set_default (gdbarch, &h8300_frame_base); /* -- 2.30.2