From 9812b2e60750cc7bbfa252d9ae8d85a72a399e01 Mon Sep 17 00:00:00 2001 From: Yao Qi Date: Mon, 21 Sep 2015 12:31:51 +0100 Subject: [PATCH] Wrap gdb_agent_op_sizes by #ifndef IN_PROCESS_AGENT Hi, I see the following build warning with recent GCC built from mainline, aarch64-none-linux-gnu-gcc -g -O2 -I. -I/home/yao/SourceCode/gnu/gdb/git/gdb/gdbserver -I/home/yao/SourceCode/gnu/gdb/git/gdb/gdbserver/../common -I/home/yao/SourceCode/gnu/gdb/git/gdb/gdbserver/../regformats -I/home/yao/SourceCode/gnu/gdb/git/gdb/gdbserver/.. -I/home/yao/SourceCode/gnu/gdb/git/gdb/gdbserver/../../include -I/home/yao/SourceCode/gnu/gdb/git/gdb/gdbserver/../gnulib/import -Ibuild-gnulib-gdbserver/import -Wall -Wpointer-arith -Wformat-nonliteral -Wno-char-subscripts -Wempty-body -Wdeclaration-after-statement -Werror -DGDBSERVER -DCONFIG_UST_GDB_INTEGRATION -fPIC -DIN_PROCESS_AGENT -fvisibility=hidden -c -o ax-ipa.o -MT ax-ipa.o -MMD -MP -MF .deps/ax-ipa.Tpo `echo " -Wall -Wpointer-arith -Wformat-nonliteral -Wno-char-subscripts -Wempty-body -Wdeclaration-after-statement " | sed "s/ -Wformat-nonliteral / -Wno-format-nonliteral /g"` /home/yao/SourceCode/gnu/gdb/git/gdb/gdbserver/ax.c /home/yao/SourceCode/gnu/gdb/git/gdb/gdbserver/ax.c:73:28: error: 'gdb_agent_op_sizes' defined but not used [-Werror=unused-const-variable] static const unsigned char gdb_agent_op_sizes [gdb_agent_op_last] = ^ cc1: all warnings being treated as errors gdb_agent_op_sizes is only used in function is_goto_target, which is defined inside #ifndef IN_PROCESS_AGENT. This warning is not arch specific, so GCC mainline for other targets should produce this warning too, although this warning is triggered by enabling aarch64 fast tracepoint. The fix is to move gdb_agent_op_sizes to gdb/gdbserver: 2015-09-21 Yao Qi * ax.c [!IN_PROCESS_AGENT] (gdb_agent_op_sizes): Define it. --- gdb/gdbserver/ChangeLog | 4 ++++ gdb/gdbserver/ax.c | 2 ++ 2 files changed, 6 insertions(+) diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 0868f0bbd8a..16b02ca969f 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,7 @@ +2015-09-21 Yao Qi + + * ax.c [!IN_PROCESS_AGENT] (gdb_agent_op_sizes): Define it. + 2015-09-21 Yao Qi * tracepoint.c (max_jump_pad_size): Remove. diff --git a/gdb/gdbserver/ax.c b/gdb/gdbserver/ax.c index d834fbb3c21..3d0d93d152d 100644 --- a/gdb/gdbserver/ax.c +++ b/gdb/gdbserver/ax.c @@ -69,6 +69,7 @@ static const char *gdb_agent_op_names [gdb_agent_op_last] = #undef DEFOP }; +#ifndef IN_PROCESS_AGENT static const unsigned char gdb_agent_op_sizes [gdb_agent_op_last] = { 0 @@ -76,6 +77,7 @@ static const unsigned char gdb_agent_op_sizes [gdb_agent_op_last] = #include "ax.def" #undef DEFOP }; +#endif /* A wrapper for gdb_agent_op_names that does some bounds-checking. */ -- 2.30.2