From 99033a63c7ba0997ef737392eef15337d6783078 Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Sat, 1 Jan 2022 13:08:20 -0500 Subject: [PATCH] gdb: copyright: make file header scan a bit more pythonic Should be functionally the same, but uses more pythonic idioms to get fewer lines of code, and to make sure to not leak open file handles. Approved-By: Simon Marchi --- gdb/copyright.py | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/gdb/copyright.py b/gdb/copyright.py index 8d623e6f5c7..040fed18708 100755 --- a/gdb/copyright.py +++ b/gdb/copyright.py @@ -148,15 +148,12 @@ def may_have_copyright_notice(filename): # so just open the file as a byte stream. We only need to search # for a pattern that should be the same regardless of encoding, # so that should be good enough. - fd = open(filename, "rb") - - lineno = 1 - for line in fd: - if b"Copyright" in line: - return True - lineno += 1 - if lineno > 50: - return False + with open(filename, "rb") as fd: + for lineno, line in enumerate(fd, start=1): + if b"Copyright" in line: + return True + if lineno > MAX_LINES: + break return False -- 2.30.2