From 9954a93ab77e64b01b95837f90a567df9e8c94df Mon Sep 17 00:00:00 2001 From: Eric Anholt Date: Wed, 2 Nov 2011 14:38:05 -0700 Subject: [PATCH] radeon: Check an error return instead of assigning it to a dead variable. Fixes gcc set-but-unused-variable warning. Reviewed-by: Alex Deucher --- .../drivers/dri/radeon/radeon_common_context.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/radeon/radeon_common_context.c b/src/mesa/drivers/dri/radeon/radeon_common_context.c index 2694dafc75f..e6c7f94af06 100644 --- a/src/mesa/drivers/dri/radeon/radeon_common_context.c +++ b/src/mesa/drivers/dri/radeon/radeon_common_context.c @@ -551,11 +551,19 @@ radeon_update_renderbuffers(__DRIcontext *context, __DRIdrawable *drawable, } ret = radeon_bo_get_tiling(bo, &tiling_flags, &pitch); - if (tiling_flags & RADEON_TILING_MACRO) - bo->flags |= RADEON_BO_FLAGS_MACRO_TILE; - if (tiling_flags & RADEON_TILING_MICRO) - bo->flags |= RADEON_BO_FLAGS_MICRO_TILE; - + if (ret) { + fprintf(stderr, + "failed to get tiling for %s %d\n", + regname, buffers[i].name); + radeon_bo_unref(bo); + bo = NULL; + continue; + } else { + if (tiling_flags & RADEON_TILING_MACRO) + bo->flags |= RADEON_BO_FLAGS_MACRO_TILE; + if (tiling_flags & RADEON_TILING_MICRO) + bo->flags |= RADEON_BO_FLAGS_MICRO_TILE; + } } if (buffers[i].attachment == __DRI_BUFFER_DEPTH) { -- 2.30.2