From 996d693a07973411897103a36e89bccee6c94479 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Sun, 8 Jul 2018 12:16:00 -0600 Subject: [PATCH] Use a previously unused variable in bfin-tdep.c This changes bfin_push_dummy_call to use the result of check_typedef. Calling check_typedef for effect was probably ok as well, but this seemed a little nicer. gdb/ChangeLog 2018-07-22 Tom Tromey * bfin-tdep.c (bfin_push_dummy_call): Use arg_type, not value_type. --- gdb/ChangeLog | 5 +++++ gdb/bfin-tdep.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 224d91ded29..8eb2cde80f7 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2018-07-22 Tom Tromey + + * bfin-tdep.c (bfin_push_dummy_call): Use arg_type, not + value_type. + 2018-07-22 Tom Tromey * windows-nat.c (saved_context): Conditionally define. diff --git a/gdb/bfin-tdep.c b/gdb/bfin-tdep.c index da62130231b..c84625c8948 100644 --- a/gdb/bfin-tdep.c +++ b/gdb/bfin-tdep.c @@ -526,7 +526,7 @@ bfin_push_dummy_call (struct gdbarch *gdbarch, { struct type *value_type = value_enclosing_type (args[i]); struct type *arg_type = check_typedef (value_type); - int container_len = (TYPE_LENGTH (value_type) + 3) & ~3; + int container_len = (TYPE_LENGTH (arg_type) + 3) & ~3; sp -= container_len; write_memory (sp, value_contents (args[i]), container_len); -- 2.30.2