From 99ef66c325a99b3e191987d8327e7e4cd4aafcd7 Mon Sep 17 00:00:00 2001 From: Eric Anholt Date: Tue, 15 Jan 2019 16:02:23 -0800 Subject: [PATCH] vc4: Don't leak the GPU fd for renderonly usage. Noticed while debugging V3D -- the ro->gpu_fd was freshly opened in ro setup, and it needs to stay open until screen close (since it may be used by renderonly) and should be the same one used by the vc4 screen. Fixes: 7029ec05e2c7 ("gallium: Add renderonly-based support for pl111+vc4.") --- src/gallium/winsys/vc4/drm/vc4_drm_winsys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/winsys/vc4/drm/vc4_drm_winsys.c b/src/gallium/winsys/vc4/drm/vc4_drm_winsys.c index b2ffa90fe19..73717d25fe4 100644 --- a/src/gallium/winsys/vc4/drm/vc4_drm_winsys.c +++ b/src/gallium/winsys/vc4/drm/vc4_drm_winsys.c @@ -37,5 +37,5 @@ vc4_drm_screen_create(int fd) struct pipe_screen * vc4_drm_screen_create_renderonly(struct renderonly *ro) { - return vc4_screen_create(fcntl(ro->gpu_fd, F_DUPFD_CLOEXEC, 3), ro); + return vc4_screen_create(ro->gpu_fd, ro); } -- 2.30.2