From 9aa939891f9d8250dde552638bb03d3f3b6ba268 Mon Sep 17 00:00:00 2001 From: Andreas Hansson Date: Wed, 18 Sep 2013 08:46:33 -0400 Subject: [PATCH] mem: Fix scheduling bug in SimpleMemory This patch ensures that a dequeue event is not scheduled if the memory controller is waiting for a retry already. Without this check it is possible for the controller to attempt sending something whilst already having one packet that is in retry, thus causing the bus to have an assertion failure. --- src/mem/simple_mem.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mem/simple_mem.cc b/src/mem/simple_mem.cc index 74d5c4ab2..2549cbe39 100644 --- a/src/mem/simple_mem.cc +++ b/src/mem/simple_mem.cc @@ -155,7 +155,7 @@ SimpleMemory::recvTimingReq(PacketPtr pkt) // the end even if the latency suggests it should be sent // before the packet(s) before it packetQueue.push_back(DeferredPacket(pkt, curTick() + getLatency())); - if (!dequeueEvent.scheduled()) + if (!retryResp && !dequeueEvent.scheduled()) schedule(dequeueEvent, packetQueue.back().tick); } else { pendingDelete.push_back(pkt); -- 2.30.2