From 9af6c38deff0f91c6c2a20d61a07a388594a39ac Mon Sep 17 00:00:00 2001 From: Dylan Baker Date: Wed, 25 Sep 2019 11:10:15 -0700 Subject: [PATCH] docs: Add use of Closes: tag for closing gitlab issues This replaces to old Bugzilla: tag, which no longer makes sense because we don't use bugzilla anymore. Reviewed-by: Eric Anholt (v1) Reviewed-by: Eric Engestrom --- docs/submittingpatches.html | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html index 786af10459e..96aed289311 100644 --- a/docs/submittingpatches.html +++ b/docs/submittingpatches.html @@ -75,11 +75,15 @@ if needed. For example: platform.
  • A "Signed-off-by:" line is not required, but not discouraged either. -
  • If a patch addresses a bugzilla issue, that should be noted in the -patch comment. For example: +
  • If a patch addresses an issue in gitlab, use the Closes: tag +For example:
    -   Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89689
    +    Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1
     
    +

    Prefer the full url to just

    Closes: #1
    , since the url makes it +easier to get to the bug page from
    git log

    +Do not use the Fixes: tag for this! Mesa already uses Fixes for something else. +
  • If a patch addresses a issue introduced with earlier commit, that should be noted in the patch comment. For example:
    -- 
    2.30.2