From 9b2eba3dcc6b41f17180e1aee29ed133f942c733 Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Wed, 5 Apr 2017 19:21:36 +0100 Subject: [PATCH] -Wwrite-strings: execute_command calls with string literals This is ugly, but it's just making the uglyness explicit. All these places would better be calling some API function directly instead of going through execute_command & friends... gdb/ChangeLog: 2017-04-05 Pedro Alves * event-top.c (command_line_handler): Add cast to execute_command call. * record-btrace.c (cmd_record_btrace_bts_start) (cmd_record_btrace_pt_start, cmd_record_btrace_start) (cmd_record_btrace_start): Add cast to execute_command call. * record-full.c (record_full_goto_insn): * record.c (record_start, record_stop): Add cast to execute_command_to_string calls. (cmd_record_start): Add cast to execute_command calls. --- gdb/ChangeLog | 12 ++++++++++++ gdb/event-top.c | 2 +- gdb/record-btrace.c | 8 ++++---- gdb/record-full.c | 2 +- gdb/record.c | 14 +++++++------- 5 files changed, 25 insertions(+), 13 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 610a1d04abf..26899e471ba 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,15 @@ +2017-04-05 Pedro Alves + + * event-top.c (command_line_handler): Add cast to execute_command + call. + * record-btrace.c (cmd_record_btrace_bts_start) + (cmd_record_btrace_pt_start, cmd_record_btrace_start) + (cmd_record_btrace_start): Add cast to execute_command call. + * record-full.c (record_full_goto_insn): + * record.c (record_start, record_stop): Add cast to + execute_command_to_string calls. + (cmd_record_start): Add cast to execute_command calls. + 2017-04-05 Pedro Alves * python/python-internal.h (gdb_PyArg_ParseTupleAndKeywords): New diff --git a/gdb/event-top.c b/gdb/event-top.c index 5d8d077a9a4..dd2770a8806 100644 --- a/gdb/event-top.c +++ b/gdb/event-top.c @@ -766,7 +766,7 @@ command_line_handler (char *rl) hung up but GDB is still alive. In such a case, we just quit gdb killing the inferior program too. */ printf_unfiltered ("quit\n"); - execute_command ("quit", 1); + execute_command ((char *) "quit", 1); } else if (cmd == NULL) { diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c index af025e2a1ca..61fba1e46f3 100644 --- a/gdb/record-btrace.c +++ b/gdb/record-btrace.c @@ -2897,7 +2897,7 @@ cmd_record_btrace_bts_start (char *args, int from_tty) TRY { - execute_command ("target record-btrace", from_tty); + execute_command ((char *) "target record-btrace", from_tty); } CATCH (exception, RETURN_MASK_ALL) { @@ -2919,7 +2919,7 @@ cmd_record_btrace_pt_start (char *args, int from_tty) TRY { - execute_command ("target record-btrace", from_tty); + execute_command ((char *) "target record-btrace", from_tty); } CATCH (exception, RETURN_MASK_ALL) { @@ -2941,7 +2941,7 @@ cmd_record_btrace_start (char *args, int from_tty) TRY { - execute_command ("target record-btrace", from_tty); + execute_command ((char *) "target record-btrace", from_tty); } CATCH (exception, RETURN_MASK_ALL) { @@ -2949,7 +2949,7 @@ cmd_record_btrace_start (char *args, int from_tty) TRY { - execute_command ("target record-btrace", from_tty); + execute_command ((char *) "target record-btrace", from_tty); } CATCH (exception, RETURN_MASK_ALL) { diff --git a/gdb/record-full.c b/gdb/record-full.c index bd95acc6b18..31ff558d2a6 100644 --- a/gdb/record-full.c +++ b/gdb/record-full.c @@ -2788,7 +2788,7 @@ record_full_goto_insn (struct record_full_entry *entry, static void cmd_record_full_start (char *args, int from_tty) { - execute_command ("target record-full", from_tty); + execute_command ((char *) "target record-full", from_tty); } static void diff --git a/gdb/record.c b/gdb/record.c index eff8fe10e19..16e5b03fe84 100644 --- a/gdb/record.c +++ b/gdb/record.c @@ -99,25 +99,25 @@ record_start (const char *method, const char *format, int from_tty) if (method == NULL) { if (format == NULL) - execute_command_to_string ("record", from_tty); + execute_command_to_string ((char *) "record", from_tty); else error (_("Invalid format.")); } else if (strcmp (method, "full") == 0) { if (format == NULL) - execute_command_to_string ("record full", from_tty); + execute_command_to_string ((char *) "record full", from_tty); else error (_("Invalid format.")); } else if (strcmp (method, "btrace") == 0) { if (format == NULL) - execute_command_to_string ("record btrace", from_tty); + execute_command_to_string ((char *) "record btrace", from_tty); else if (strcmp (format, "bts") == 0) - execute_command_to_string ("record btrace bts", from_tty); + execute_command_to_string ((char *) "record btrace bts", from_tty); else if (strcmp (format, "pt") == 0) - execute_command_to_string ("record btrace pt", from_tty); + execute_command_to_string ((char *) "record btrace pt", from_tty); else error (_("Invalid format.")); } @@ -130,7 +130,7 @@ record_start (const char *method, const char *format, int from_tty) void record_stop (int from_tty) { - execute_command_to_string ("record stop", from_tty); + execute_command_to_string ((char *) "record stop", from_tty); } /* See record.h. */ @@ -265,7 +265,7 @@ show_record_debug (struct ui_file *file, int from_tty, static void cmd_record_start (char *args, int from_tty) { - execute_command ("target record-full", from_tty); + execute_command ((char *) "target record-full", from_tty); } /* Truncate the record log from the present point -- 2.30.2