From 9b807e7bbbc55168e91c262c98fd09397482f9c9 Mon Sep 17 00:00:00 2001 From: "Maciej W. Rozycki" Date: Fri, 3 Oct 2014 17:38:39 +0100 Subject: [PATCH] Also mark ELF solib trampoline minimal symbols special In installing minimal symbols for ELF shared library trampolines we "forget" to make individual symbols special where required. This leads to problems on the MIPS target using microMIPS SVR4 lazy stubs. Lacking the special annotation these stubs are treated as standard MIPS code and this makes GDB insert the wrong software breakpoint instruction, breaking e.g. single-stepping through these stubs. This is not a very frequent scenario as microMIPS SVR4 lazy stubs are typically only used in shared libraries with the main executable using PLT, handled elsewhere. Still it triggers e.g. when a software watchpoint has been installed. The symptom is SIGILL or the program going astray, depending on the endianness. Disassembly of these stubs is also wrong. * elfread.c (elf_symtab_read): Also mark solib trampoline minimal symbols special. --- gdb/ChangeLog | 5 +++++ gdb/elfread.c | 5 ++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 757cc690f22..6387550c5b6 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2014-10-03 Maciej W. Rozycki + + * elfread.c (elf_symtab_read): Also mark solib trampoline minimal + symbols special. + 2014-10-03 Maciej W. Rozycki * breakpoint.h (bp_target_info): Add `reqstd_address' member, diff --git a/gdb/elfread.c b/gdb/elfread.c index 9b8233cc829..19aaed35dc8 100644 --- a/gdb/elfread.c +++ b/gdb/elfread.c @@ -328,7 +328,10 @@ elf_symtab_read (struct objfile *objfile, int type, (sym->name, strlen (sym->name), copy_names, symaddr, mst_solib_trampoline, sect, objfile); if (msym != NULL) - msym->filename = filesymname; + { + msym->filename = filesymname; + gdbarch_elf_make_msymbol_special (gdbarch, sym, msym); + } continue; } -- 2.30.2