From 9bbc95654de572e68a6afe4dd892721d34304ed6 Mon Sep 17 00:00:00 2001 From: Paolo Carlini Date: Mon, 20 May 2013 17:13:47 +0000 Subject: [PATCH] re PR c++/12288 (unintelligible error message for constructor declaration with misspelled type) /cp 2013-05-20 Paolo Carlini PR c++/12288 * parser.c (cp_parser_parameter_declaration): Check return value of cp_parser_parse_and_diagnose_invalid_type_name. /testsuite 2013-05-20 Paolo Carlini PR c++/12288 * g++.dg/parse/error52.C: New. * g++.dg/parse/error3.C: Adjust. * g++.dg/parse/error36.C: Likewise. From-SVN: r199115 --- gcc/cp/ChangeLog | 6 ++++++ gcc/cp/parser.c | 5 +++-- gcc/testsuite/ChangeLog | 7 +++++++ gcc/testsuite/g++.dg/parse/error3.C | 1 - gcc/testsuite/g++.dg/parse/error36.C | 1 - gcc/testsuite/g++.dg/parse/error52.C | 11 +++++++++++ 6 files changed, 27 insertions(+), 4 deletions(-) create mode 100644 gcc/testsuite/g++.dg/parse/error52.C diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index b08afd929f5..d1e3bb65c36 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,9 @@ +2013-05-20 Paolo Carlini + + PR c++/12288 + * parser.c (cp_parser_parameter_declaration): Check return value + of cp_parser_parse_and_diagnose_invalid_type_name. + 2013-05-20 Jason Merrill PR c++/57319 diff --git a/gcc/cp/parser.c b/gcc/cp/parser.c index 91e6615ae38..c3096d372ab 100644 --- a/gcc/cp/parser.c +++ b/gcc/cp/parser.c @@ -17844,8 +17844,9 @@ cp_parser_parameter_declaration (cp_parser *parser, &declares_class_or_enum); /* Complain about missing 'typename' or other invalid type names. */ - if (!decl_specifiers.any_type_specifiers_p) - cp_parser_parse_and_diagnose_invalid_type_name (parser); + if (!decl_specifiers.any_type_specifiers_p + && cp_parser_parse_and_diagnose_invalid_type_name (parser)) + decl_specifiers.type = error_mark_node; /* If an error occurred, there's no reason to attempt to parse the rest of the declaration. */ diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 85aac1e2a10..4e8e6e4282d 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,10 @@ +2013-05-20 Paolo Carlini + + PR c++/12288 + * g++.dg/parse/error52.C: New. + * g++.dg/parse/error3.C: Adjust. + * g++.dg/parse/error36.C: Likewise. + 2013-05-20 Oleg Endo PR target/56547 diff --git a/gcc/testsuite/g++.dg/parse/error3.C b/gcc/testsuite/g++.dg/parse/error3.C index 58739934156..938ab45b24c 100644 --- a/gcc/testsuite/g++.dg/parse/error3.C +++ b/gcc/testsuite/g++.dg/parse/error3.C @@ -5,5 +5,4 @@ static void InstantiateConstraint(const float&, unsigned, void(*AddFunction)(const TYPE&,bool&, char*, char*, unsigned*)); -// { dg-error "64: ISO C\\+\\+ forbids declaration of 'parameter' with no type" "forbids" { target *-*-* } { 5 } } // { dg-error "60: 'TYPE' does not name a type" "does not" { target *-*-* } { 5 } } diff --git a/gcc/testsuite/g++.dg/parse/error36.C b/gcc/testsuite/g++.dg/parse/error36.C index a99ad299d39..92e27a928df 100644 --- a/gcc/testsuite/g++.dg/parse/error36.C +++ b/gcc/testsuite/g++.dg/parse/error36.C @@ -26,7 +26,6 @@ template struct B // PR c++/40738 template void g(const A::type &t); // { dg-error "typename" "typename" } -// { dg-error "no type" "no type" { target *-*-* } 28 } // PR c++/18451 template A::B A::b; // { dg-error "typename" } diff --git a/gcc/testsuite/g++.dg/parse/error52.C b/gcc/testsuite/g++.dg/parse/error52.C new file mode 100644 index 00000000000..d1c6e4a857d --- /dev/null +++ b/gcc/testsuite/g++.dg/parse/error52.C @@ -0,0 +1,11 @@ +// PR c++/12288 + +class X {}; + +struct S { + explicit S (const X::T&) {} // { dg-error "does not name a type" } +}; + +class Y {}; + +typedef Y::T xt; // { dg-error "does not name a type" } -- 2.30.2