From 9c37696b249b48558ff2162259fc77360c38f28e Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Fri, 19 Apr 2013 15:37:31 +0000 Subject: [PATCH] -Wpointer-sign: record.c. MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit ../../src/gdb/record.c: In function ‘set_record_insn_history_size’: ../../src/gdb/record.c:670:5: error: pointer targets in passing argument 2 of ‘validate_history_size’ differ in signedness [-Werror=pointer-sign] ../../src/gdb/record.c:646:1: note: expected ‘int *’ but argument is of type ‘unsigned int *’ ../../src/gdb/record.c: In function ‘set_record_call_history_size’: ../../src/gdb/record.c:682:5: error: pointer targets in passing argument 2 of ‘validate_history_size’ differ in signedness [-Werror=pointer-sign] ../../src/gdb/record.c:646:1: note: expected ‘int *’ but argument is of type ‘unsigned int *’ This fixes it in the obvious way. gdb/ 2013-04-19 Pedro Alves * record.c (validate_history_size): Make parameter 'setting' unsigned. --- gdb/ChangeLog | 5 +++++ gdb/record.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 379c8d22ec7..191ef31463e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2013-04-19 Pedro Alves + + * record.c (validate_history_size): Make parameter 'setting' + unsigned. + 2013-04-19 Pedro Alves * ctf.c (ctf_write_uploaded_tsv, ctf_write_uploaded_tp): Add casts diff --git a/gdb/record.c b/gdb/record.c index 0a7f0a1aa50..76d9fd2d7a9 100644 --- a/gdb/record.c +++ b/gdb/record.c @@ -643,7 +643,7 @@ cmd_record_call_history (char *arg, int from_tty) is the real setting the command allows changing. */ static void -validate_history_size (unsigned int *command_var, int *setting) +validate_history_size (unsigned int *command_var, unsigned int *setting) { if (*command_var != UINT_MAX && *command_var > INT_MAX) { -- 2.30.2