From 9c38eb65ac759526a693246efbc70d6f4b590a9d Mon Sep 17 00:00:00 2001 From: Jim Kingdon Date: Thu, 21 Oct 1993 05:22:34 +0000 Subject: [PATCH] * target.h: Put remote_debug declaration back here. Add baud_rate. * remote.c, remote-udi.c, remote-utils.h: Let target.h take care of declaring these. Those random externs all over are error prone. * Move "set remotebaud" from remote-utils.c to main.c to it applies to remote.c as well. * xcoffread.c (xcoff_symfile_read), coffread.c (coff_symfile_read): Sort symtabs for this objfile only, not for all objfiles. * symfile.c, symfile.h (sort_all_symtab_syms): Remove; no longer used. --- gdb/ChangeLog | 6 ++++++ gdb/coffread.c | 11 +++++++---- gdb/remote-udi.c | 1 - gdb/remote-utils.h | 2 -- gdb/remote.c | 4 ---- 5 files changed, 13 insertions(+), 11 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 786bffff04e..2f333df7b1b 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,11 @@ Wed Oct 20 11:35:43 1993 Jim Kingdon (kingdon@lioth.cygnus.com) + * target.h: Put remote_debug declaration back here. Add baud_rate. + * remote.c, remote-udi.c, remote-utils.h: Let target.h take care of + declaring these. Those random externs all over are error prone. + * Move "set remotebaud" from remote-utils.c to main.c to it applies + to remote.c as well. + * xcoffread.c (xcoff_symfile_read), coffread.c (coff_symfile_read): Sort symtabs for this objfile only, not for all objfiles. * symfile.c, symfile.h (sort_all_symtab_syms): Remove; no longer used. diff --git a/gdb/coffread.c b/gdb/coffread.c index 415ee18b4aa..ffe00d5c813 100644 --- a/gdb/coffread.c +++ b/gdb/coffread.c @@ -662,10 +662,13 @@ coff_symfile_read (objfile, section_offsets, mainline) /* Sort symbols alphabetically within each block. */ - for (s = objfile -> symtabs; s != NULL; s = s -> next) - { - sort_symtab_syms (s); - } + { + struct symtab *s; + for (s = objfile -> symtabs; s != NULL; s = s -> next) + { + sort_symtab_syms (s); + } + } /* Install any minimal symbols that have been collected as the current minimal symbols for this objfile. */ diff --git a/gdb/remote-udi.c b/gdb/remote-udi.c index 30444581c35..8feee27c4cf 100644 --- a/gdb/remote-udi.c +++ b/gdb/remote-udi.c @@ -50,7 +50,6 @@ Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ /* access the register store directly, without going through the normal handler functions. This avoids an extra data copy. */ -extern int remote_debug; extern int stop_soon_quietly; /* for wait_for_inferior */ extern struct value *call_function_by_hand(); static void udi_resume PARAMS ((int pid, int step, int sig)); diff --git a/gdb/remote-utils.h b/gdb/remote-utils.h index 59f4d3b3706..477f8bff19f 100644 --- a/gdb/remote-utils.h +++ b/gdb/remote-utils.h @@ -39,8 +39,6 @@ struct _sr_settings { }; extern struct _sr_settings sr_settings; -extern int remote_debug; -extern int baud_rate; /* get and set debug value. */ #define sr_get_debug() (remote_debug) diff --git a/gdb/remote.c b/gdb/remote.c index 266d5f389de..9bc32dac166 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -213,10 +213,6 @@ interrupt_query PARAMS ((void)); extern struct target_ops remote_ops; /* Forward decl */ -extern int baud_rate; - -extern int remote_debug; - /* This was 5 seconds, which is a long time to sit and wait. Unless this is going though some terminal server or multiplexer or other form of hairy serial connection, I would think 2 seconds would -- 2.30.2