From 9c3da8cc5d01dcccfd98cda20753081414f12877 Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Tue, 25 Feb 2020 22:10:48 +0100 Subject: [PATCH] typo fix: Fix probablity, becuse, sucessor and destinarion typos [PR93912] 2020-02-25 Jakub Jelinek PR other/93912 * config/sh/sh.c (expand_cbranchdi4): Fix comment typo, probablity -> probability. * cfghooks.c (verify_flow_info): Likewise. * predict.c (combine_predictions_for_bb): Likewise. * bb-reorder.c (connect_better_edge_p): Likewise. Fix comment typo, sucessor -> successor. (find_traces_1_round): Fix comment typo, destinarion -> destination. * omp-expand.c (expand_oacc_for): Fix comment typo, sucessors -> successors. * tree-ssa-loop-ch.c (should_duplicate_loop_header_p): Fix dump message typo, sucessors -> successors. c/ * gimple-parser.c (c_parser_gimple_parse_bb_spec_edge_probability): Rename last argument from probablity to probability. --- gcc/ChangeLog | 15 +++++++++++++++ gcc/bb-reorder.c | 6 +++--- gcc/c/ChangeLog | 6 ++++++ gcc/c/gimple-parser.c | 7 ++++--- gcc/cfghooks.c | 4 ++-- gcc/config/sh/sh.c | 2 +- gcc/omp-expand.c | 4 ++-- gcc/predict.c | 2 +- gcc/tree-ssa-loop-ch.c | 2 +- 9 files changed, 35 insertions(+), 13 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 0e9c02c02ff..724df77c4d2 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,18 @@ +2020-02-25 Jakub Jelinek + + PR other/93912 + * config/sh/sh.c (expand_cbranchdi4): Fix comment typo, probablity + -> probability. + * cfghooks.c (verify_flow_info): Likewise. + * predict.c (combine_predictions_for_bb): Likewise. + * bb-reorder.c (connect_better_edge_p): Likewise. Fix comment typo, + sucessor -> successor. + (find_traces_1_round): Fix comment typo, destinarion -> destination. + * omp-expand.c (expand_oacc_for): Fix comment typo, sucessors -> + successors. + * tree-ssa-loop-ch.c (should_duplicate_loop_header_p): Fix dump + message typo, sucessors -> successors. + 2020-02-25 Martin Sebor * doc/extend.texi (attribute access): Correct an example. diff --git a/gcc/bb-reorder.c b/gcc/bb-reorder.c index ecd3103838e..c635010c69f 100644 --- a/gcc/bb-reorder.c +++ b/gcc/bb-reorder.c @@ -592,7 +592,7 @@ find_traces_1_round (int branch_th, profile_count count_th, /* If the best destination has multiple successors or predecessors, don't allow it to be added when optimizing for size. This makes sure predecessors with smaller index are handled before the best - destinarion. It breaks long trace and reduces long jumps. + destination. It breaks long trace and reduces long jumps. Take if-then-else as an example. A @@ -1023,8 +1023,8 @@ connect_better_edge_p (const_edge e, bool src_index_p, int best_len, e_index = e->src->index; /* We are looking for predecessor, so probabilities are not that - informative. We do not want to connect A to B becuse A has - only one sucessor (probablity is 100%) while there is edge + informative. We do not want to connect A to B because A has + only one successor (probability is 100%) while there is edge A' to B where probability is 90% but which is much more frequent. */ if (e->count () > cur_best_edge->count ()) /* The edge has higher probability than the temporary best edge. */ diff --git a/gcc/c/ChangeLog b/gcc/c/ChangeLog index e88337b18a0..83bf651c41f 100644 --- a/gcc/c/ChangeLog +++ b/gcc/c/ChangeLog @@ -1,3 +1,9 @@ +2020-02-25 Jakub Jelinek + + PR other/93912 + * gimple-parser.c (c_parser_gimple_parse_bb_spec_edge_probability): + Rename last argument from probablity to probability. + 2020-02-13 Jakub Jelinek PR c/93576 diff --git a/gcc/c/gimple-parser.c b/gcc/c/gimple-parser.c index 3370178be18..4e8ff5b1c4f 100644 --- a/gcc/c/gimple-parser.c +++ b/gcc/c/gimple-parser.c @@ -149,12 +149,13 @@ static bool c_parser_gimple_parse_bb_spec_edge_probability (tree val, gimple_parser &parser, int *index, - profile_probability *probablity) + profile_probability + *probability) { bool return_p = c_parser_gimple_parse_bb_spec (val, index); if (return_p) { - *probablity = profile_probability::uninitialized (); + *probability = profile_probability::uninitialized (); /* Parse frequency if provided. */ if (c_parser_next_token_is (parser, CPP_OPEN_PAREN)) { @@ -188,7 +189,7 @@ c_parser_gimple_parse_bb_spec_edge_probability (tree val, } unsigned int value = TREE_INT_CST_LOW (f); - *probablity = profile_probability (value, quality); + *probability = profile_probability (value, quality); c_parser_consume_token (parser); if (!c_parser_require (parser, CPP_CLOSE_PAREN, "expected %<)%>")) diff --git a/gcc/cfghooks.c b/gcc/cfghooks.c index db8623211e4..ea558b46947 100644 --- a/gcc/cfghooks.c +++ b/gcc/cfghooks.c @@ -153,7 +153,7 @@ verify_flow_info (void) err = 1; } /* FIXME: Graphite and SLJL and target code still tends to produce - edges with no probablity. */ + edges with no probability. */ if (profile_status_for_fn (cfun) >= PROFILE_GUESSED && !bb->count.initialized_p () && !flag_graphite && 0) { @@ -170,7 +170,7 @@ verify_flow_info (void) err = 1; } /* FIXME: Graphite and SLJL and target code still tends to produce - edges with no probablity. */ + edges with no probability. */ if (profile_status_for_fn (cfun) >= PROFILE_GUESSED && !e->probability.initialized_p () && !flag_graphite && 0) { diff --git a/gcc/config/sh/sh.c b/gcc/config/sh/sh.c index a178cfd3b9c..84c0ea025b4 100644 --- a/gcc/config/sh/sh.c +++ b/gcc/config/sh/sh.c @@ -2108,7 +2108,7 @@ expand_cbranchdi4 (rtx *operands, enum rtx_code comparison) lsw_taken = EQ; if (prob.initialized_p ()) { - /* FIXME: This is not optimal. We do not really know the probablity + /* FIXME: This is not optimal. We do not really know the probability that values differ by MCW only, but we should probably distribute probabilities more evenly. */ msw_skip_prob = rev_prob; diff --git a/gcc/omp-expand.c b/gcc/omp-expand.c index cd423ad799e..a642ccc9980 100644 --- a/gcc/omp-expand.c +++ b/gcc/omp-expand.c @@ -6029,8 +6029,8 @@ expand_oacc_for (struct omp_region *region, struct omp_for_data *fd) basic_block cont_bb = region->cont; /* BB ending in OMP_CONTINUE */ basic_block bottom_bb = NULL; - /* entry_bb has two sucessors; the branch edge is to the exit - block, fallthrough edge to body. */ + /* entry_bb has two successors; the branch edge is to the exit + block, fallthrough edge to body. */ gcc_assert (EDGE_COUNT (entry_bb->succs) == 2 && BRANCH_EDGE (entry_bb)->dest == exit_bb); diff --git a/gcc/predict.c b/gcc/predict.c index 1b000581c8f..a7ae977c866 100644 --- a/gcc/predict.c +++ b/gcc/predict.c @@ -1367,7 +1367,7 @@ combine_predictions_for_bb (basic_block bb, bool dry_run) /* If we have only one successor which is unknown, we can compute missing - probablity. */ + probability. */ if (nunknown == 1) { profile_probability prob = profile_probability::always (); diff --git a/gcc/tree-ssa-loop-ch.c b/gcc/tree-ssa-loop-ch.c index 23354f0aa61..b9002d8e294 100644 --- a/gcc/tree-ssa-loop-ch.c +++ b/gcc/tree-ssa-loop-ch.c @@ -83,7 +83,7 @@ should_duplicate_loop_header_p (basic_block header, class loop *loop, { if (dump_file && (dump_flags & TDF_DETAILS)) fprintf (dump_file, - " Not duplicating bb %i: both sucessors are in loop.\n", + " Not duplicating bb %i: both successors are in loop.\n", loop->num); return false; } -- 2.30.2