From 9c725245beed2f056b67f5dc218fef6cb869c5f2 Mon Sep 17 00:00:00 2001 From: Segher Boessenkool Date: Fri, 24 Apr 2020 13:33:14 +0000 Subject: [PATCH] rs6000: Properly handle LE index munging in vec_shr (PR94710) The PR shows the compiler crashing with -mvsx -mlittle -O0. This turns out to be caused by a failure to make of the higher bits in an index endian conversion. 2020-04-24 Segher Boessenkool PR target/94710 * config/rs6000/vector.md (vec_shr_ for VEC_L): Correct little endian byteshift_val calculation. --- gcc/ChangeLog | 6 ++++++ gcc/config/rs6000/vector.md | 3 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 2db3413a973..4b6456e2416 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2020-04-24 Segher Boessenkool + + PR target/94710 + * config/rs6000/vector.md (vec_shr_ for VEC_L): Correct little + endian byteshift_val calculation. + 2020-04-24 Andrew Stubbs * config/gcn/gcn.md (*mov_insn): Only split post-reload. diff --git a/gcc/config/rs6000/vector.md b/gcc/config/rs6000/vector.md index 5bc8f802504..662521e74fe 100644 --- a/gcc/config/rs6000/vector.md +++ b/gcc/config/rs6000/vector.md @@ -1426,7 +1426,8 @@ emit_move_insn (zero_reg, CONST0_RTX (mode)); if (!BYTES_BIG_ENDIAN) { - byteshift_val = 16 - byteshift_val; + /* Note, byteshift_val can be 0! */ + byteshift_val = -byteshift_val & 15; op1 = zero_reg; op2 = operands[1]; } -- 2.30.2