From 9cfd4ed49d84fb0fc8c4c152297a95958514b6cb Mon Sep 17 00:00:00 2001 From: =?utf8?q?Cl=C3=A9ment=20Chigot?= Date: Wed, 14 Sep 2022 13:12:32 +0200 Subject: [PATCH] ld/testsuite: force warnings when dealing with execstack tests Binutils can be configured to avoid printing the execstack or RWD segment warnings. In this case, the first test of PR ld/29072 will fail. Fix that by always manually forcing the warnings for it. ld/ChangeLog: * testsuite/ld-elf/elf.exp (PR ld/29072): Force execstack and RWD segment warnings. --- ld/testsuite/ld-elf/elf.exp | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/ld/testsuite/ld-elf/elf.exp b/ld/testsuite/ld-elf/elf.exp index 64b1d34f055..e4d8bee2f53 100644 --- a/ld/testsuite/ld-elf/elf.exp +++ b/ld/testsuite/ld-elf/elf.exp @@ -237,18 +237,11 @@ if { [istarget *-*-*linux*] return $text } - # The HPPA target disables the warnings by default since it needs an - # executable stack to support older kernels and an RWX segment to - # support its PLT. MIPS also turns off exec stack warnings. - if { [istarget "hppa*-*-*"] || [istarget mips*-*-*] } { - set extra_link_opts "--warn-execstack --warn-rwx-segments" - } else { - set extra_link_opts "" - } - + # Since the warnings can be disabled by configure, ensure consistency + # of the first test by forcing the flags. run_ld_link_tests [list \ [list "PR ld/29072 (warn about an executable .note.GNU-stack)" \ - "-e 0 $extra_link_opts" \ + "-e 0 --warn-execstack --warn-rwx-segments" \ "" \ "" \ {pr29072-a.s} \ -- 2.30.2