From 9d4d9d34d82646e4e7781bb25a64174d35680578 Mon Sep 17 00:00:00 2001 From: Yuanhan Liu Date: Wed, 9 Nov 2011 14:55:53 +0800 Subject: [PATCH] ir_to_mesa: don't init unfirom if link failed Don't call set_unfiform_initializers if link failed, or it would trigger a GL_INVALID_OPERATION error. That's not an expected behavior of glLinkProgram function. Signed-off-by: Yuanhan Liu Reviewed-by: Paul Berry --- src/mesa/program/ir_to_mesa.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.cpp index 0dd44bd7922..5cee8377811 100644 --- a/src/mesa/program/ir_to_mesa.cpp +++ b/src/mesa/program/ir_to_mesa.cpp @@ -3458,7 +3458,9 @@ _mesa_glsl_link_shader(struct gl_context *ctx, struct gl_shader_program *prog) } } - set_uniform_initializers(ctx, prog); + if (prog->LinkStatus) { + set_uniform_initializers(ctx, prog); + } if (ctx->Shader.Flags & GLSL_DUMP) { if (!prog->LinkStatus) { -- 2.30.2