From 9d8dbe732a0df0604dd1a2db1e4495e3eba686a8 Mon Sep 17 00:00:00 2001 From: Jonathan Wakely Date: Mon, 2 Mar 2015 17:50:55 +0000 Subject: [PATCH] re PR libstdc++/65279 (std::scoped_allocator_adaptor is not assignable) PR libstdc++/65279 * include/std/scoped_allocator (__inner_type_impl, scoped_allocator_adaptor): Add defaulted copy assignment and move assignment operators. * testsuite/20_util/scoped_allocator/65279.cc: New. From-SVN: r221119 --- libstdc++-v3/ChangeLog | 8 +++ libstdc++-v3/include/std/scoped_allocator | 10 ++++ .../20_util/scoped_allocator/65279.cc | 54 +++++++++++++++++++ 3 files changed, 72 insertions(+) create mode 100644 libstdc++-v3/testsuite/20_util/scoped_allocator/65279.cc diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog index 45a0f8c0b69..33a90dc5127 100644 --- a/libstdc++-v3/ChangeLog +++ b/libstdc++-v3/ChangeLog @@ -1,3 +1,11 @@ +2015-03-02 Jonathan Wakely + + PR libstdc++/65279 + * include/std/scoped_allocator (__inner_type_impl, + scoped_allocator_adaptor): Add defaulted copy assignment and move + assignment operators. + * testsuite/20_util/scoped_allocator/65279.cc: New. + 2015-03-02 Jonathan Wakely PR libstdc++/64367 diff --git a/libstdc++-v3/include/std/scoped_allocator b/libstdc++-v3/include/std/scoped_allocator index 1be10b294cd..d163edd109a 100644 --- a/libstdc++-v3/include/std/scoped_allocator +++ b/libstdc++-v3/include/std/scoped_allocator @@ -105,6 +105,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION __inner_type_impl() = default; __inner_type_impl(const __inner_type_impl&) = default; __inner_type_impl(__inner_type_impl&&) = default; + __inner_type_impl& operator=(const __inner_type_impl&) = default; + __inner_type_impl& operator=(__inner_type_impl&&) = default; template __inner_type_impl(const __inner_type_impl<_Alloc>& __other) @@ -136,6 +138,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION __inner_type_impl() = default; __inner_type_impl(const __inner_type_impl&) = default; __inner_type_impl(__inner_type_impl&&) = default; + __inner_type_impl& operator=(const __inner_type_impl&) = default; + __inner_type_impl& operator=(__inner_type_impl&&) = default; template __inner_type_impl(const __inner_type_impl<_Allocs...>& __other) @@ -310,6 +314,12 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION _M_inner(std::move(__other._M_inner)) { } + scoped_allocator_adaptor& + operator=(const scoped_allocator_adaptor&) = default; + + scoped_allocator_adaptor& + operator=(scoped_allocator_adaptor&&) = default; + inner_allocator_type& inner_allocator() noexcept { return _M_inner._M_get(this); } diff --git a/libstdc++-v3/testsuite/20_util/scoped_allocator/65279.cc b/libstdc++-v3/testsuite/20_util/scoped_allocator/65279.cc new file mode 100644 index 00000000000..786d4031cdb --- /dev/null +++ b/libstdc++-v3/testsuite/20_util/scoped_allocator/65279.cc @@ -0,0 +1,54 @@ +// Copyright (C) 2015 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// . + +// { dg-options "-std=gnu++11" } +// { dg-do compile } + +#include +#include +#include + +template + struct Allocator : std::allocator + { + template + struct rebind { using other = Allocator; }; + + using propagate_on_container_copy_assignment = std::true_type; + using propagate_on_container_move_assignment = std::true_type; + }; + +template + using alloc = std::scoped_allocator_adaptor...>; + +void +test01() +{ + // Test partial specialization for sizeof...(InnerAlloc) == 0 + alloc a; + a = a; + a = std::move(a); +} + +void +test02() +{ + // Test partial specialization for sizeof...(InnerAlloc) >= 1 + alloc a; + a = a; + a = std::move(a); +} -- 2.30.2