From 9dd1dda146443f1672b198c3cc349013f30578fe Mon Sep 17 00:00:00 2001 From: Nikos Nikoleris Date: Mon, 31 Aug 2020 08:23:20 +0300 Subject: [PATCH] sim: Add missing overrides in the *Fault classes Change-Id: I7a74df78f0f85ccf7fd896f98b301c1f998c1497 Signed-off-by: Nikos Nikoleris Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/33777 Reviewed-by: Gabe Black Reviewed-by: Jason Lowe-Power Maintainer: Gabe Black Tested-by: kokoro --- src/sim/faults.hh | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/sim/faults.hh b/src/sim/faults.hh index e9a57c6b4..4b5c1a52f 100644 --- a/src/sim/faults.hh +++ b/src/sim/faults.hh @@ -55,7 +55,11 @@ class UnimpFault : public FaultBase public: UnimpFault(std::string _str) : panicStr(_str) {} - FaultName name() const { return "Unimplemented simulator feature"; } + FaultName + name() const override + { + return "Unimplemented simulator feature"; + } void invoke(ThreadContext *tc, const StaticInstPtr &inst = StaticInst::nullStaticInstPtr) override; }; @@ -63,7 +67,7 @@ class UnimpFault : public FaultBase class ReExec : public FaultBase { public: - virtual FaultName name() const { return "Re-execution fault"; } + virtual FaultName name() const override { return "Re-execution fault"; } void invoke(ThreadContext *tc, const StaticInstPtr &inst= StaticInst::nullStaticInstPtr) override; }; @@ -78,7 +82,7 @@ class ReExec : public FaultBase class SyscallRetryFault : public FaultBase { public: - virtual FaultName name() const { return "System call retry fault"; } + FaultName name() const override { return "System call retry fault"; } SyscallRetryFault() {} void invoke(ThreadContext *tc, const StaticInstPtr &inst= StaticInst::nullStaticInstPtr) override; @@ -89,7 +93,7 @@ class GenericPageTableFault : public FaultBase private: Addr vaddr; public: - FaultName name() const { return "Generic page table fault"; } + FaultName name() const override { return "Generic page table fault"; } GenericPageTableFault(Addr va) : vaddr(va) {} void invoke(ThreadContext *tc, const StaticInstPtr &inst= StaticInst::nullStaticInstPtr) override; @@ -101,7 +105,7 @@ class GenericAlignmentFault : public FaultBase private: Addr vaddr; public: - FaultName name() const { return "Generic alignment fault"; } + FaultName name() const override { return "Generic alignment fault"; } GenericAlignmentFault(Addr va) : vaddr(va) {} void invoke(ThreadContext *tc, const StaticInstPtr &inst= StaticInst::nullStaticInstPtr) override; -- 2.30.2