From 9de667af6e92ab709850dfc4ab25e48093e351ba Mon Sep 17 00:00:00 2001 From: Gabe Black Date: Fri, 18 Sep 2020 23:07:00 -0700 Subject: [PATCH] sim: Remove check whether the System port is connected. The port will report an error if something tries to use it and it's not connected. If it isn't needed, there's no reason to force users to hook something up to it just to satisfy the check. Change-Id: I0668b8a86c8cb323aba51670fb7914d35acc5198 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/34815 Maintainer: Gabe Black Tested-by: kokoro Reviewed-by: Nikos Nikoleris Reviewed-by: Jason Lowe-Power Reviewed-by: Andreas Sandberg --- src/sim/system.cc | 8 -------- src/sim/system.hh | 5 ----- 2 files changed, 13 deletions(-) diff --git a/src/sim/system.cc b/src/sim/system.cc index cbc30a903..39b3414a0 100644 --- a/src/sim/system.cc +++ b/src/sim/system.cc @@ -272,14 +272,6 @@ System::~System() delete workItemStats[j]; } -void -System::init() -{ - // check that the system port is connected - if (!_systemPort.isConnected()) - panic("System port on %s is not connected.\n", name()); -} - void System::startup() { diff --git a/src/sim/system.hh b/src/sim/system.hh index fc93b85f7..e5d4ec625 100644 --- a/src/sim/system.hh +++ b/src/sim/system.hh @@ -221,11 +221,6 @@ class System : public SimObject, public PCEventScope const_iterator end() const { return const_iterator(*this, size()); } }; - /** - * After all objects have been created and all ports are - * connected, check that the system port is connected. - */ - void init() override; void startup() override; /** -- 2.30.2