From 9e2d426c17e882e117af872b103f9ac2866b5132 Mon Sep 17 00:00:00 2001 From: Jonathan Wakely Date: Tue, 11 Sep 2018 12:50:39 +0100 Subject: [PATCH] PR libstdc++/87278 restore support for std::make_shared() PR libstdc++/87278 * include/bits/shared_ptr.h (make_shared): Use remove_cv instead of remove_const. * testsuite/20_util/shared_ptr/creation/87278.cc: New test. From-SVN: r264207 --- libstdc++-v3/ChangeLog | 5 ++++ libstdc++-v3/include/bits/shared_ptr.h | 2 +- .../20_util/shared_ptr/creation/87278.cc | 26 +++++++++++++++++++ 3 files changed, 32 insertions(+), 1 deletion(-) create mode 100644 libstdc++-v3/testsuite/20_util/shared_ptr/creation/87278.cc diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog index 1a1a535532e..b23dfe47d19 100644 --- a/libstdc++-v3/ChangeLog +++ b/libstdc++-v3/ChangeLog @@ -1,5 +1,10 @@ 2018-09-11 Jonathan Wakely + PR libstdc++/87278 + * include/bits/shared_ptr.h (make_shared): Use remove_cv instead of + remove_const. + * testsuite/20_util/shared_ptr/creation/87278.cc: New test. + Implement LWG 2905 changes to constrain unique_ptr constructors * include/bits/unique_ptr.h (__uniq_ptr_impl): Add assertions to check deleter type. diff --git a/libstdc++-v3/include/bits/shared_ptr.h b/libstdc++-v3/include/bits/shared_ptr.h index 2a82f186328..d7b044b83cd 100644 --- a/libstdc++-v3/include/bits/shared_ptr.h +++ b/libstdc++-v3/include/bits/shared_ptr.h @@ -714,7 +714,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION inline shared_ptr<_Tp> make_shared(_Args&&... __args) { - typedef typename std::remove_const<_Tp>::type _Tp_nc; + typedef typename std::remove_cv<_Tp>::type _Tp_nc; return std::allocate_shared<_Tp>(std::allocator<_Tp_nc>(), std::forward<_Args>(__args)...); } diff --git a/libstdc++-v3/testsuite/20_util/shared_ptr/creation/87278.cc b/libstdc++-v3/testsuite/20_util/shared_ptr/creation/87278.cc new file mode 100644 index 00000000000..04ab36734d2 --- /dev/null +++ b/libstdc++-v3/testsuite/20_util/shared_ptr/creation/87278.cc @@ -0,0 +1,26 @@ +// Copyright (C) 2018 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// . + +// { dg-do compile { target c++11 } } + +#include + +void +test01() +{ + std::make_shared(); +} -- 2.30.2