From 9e8332ebc271e9188b645c7600c0cf6202185fac Mon Sep 17 00:00:00 2001 From: Adam Jackson Date: Fri, 9 Nov 2018 11:37:42 -0500 Subject: [PATCH] specs: Remove GLX_RENDERER_ID_MESA from GLX_MESA_query_renderer This has not even had an attempt at implementation. If you asked for renderer 0 - which, the spec implies, should always work - then dri2_convert_glx_attribs would fail, we'd silently fall back to creating an indirect context, and xserver would also not recognize the attribute and would throw BadValue at you. The API would be difficult to use in any case, since there's no way to enumerate how many renderers the screen has. I'd be tempted to add that by defining: glXQueryRendererIntegerMESA(dpy, screen, /* renderer = */ -1, 0, &value); to return the number of renderers, but a new entrypoint might be cleaner. Still, better to not specify it at all than to lie about it. Reviewed-by: Emil Velikov Signed-off-by: Adam Jackson --- docs/specs/MESA_query_renderer.spec | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/docs/specs/MESA_query_renderer.spec b/docs/specs/MESA_query_renderer.spec index 3b4a445cf88..0209efa1148 100644 --- a/docs/specs/MESA_query_renderer.spec +++ b/docs/specs/MESA_query_renderer.spec @@ -92,11 +92,6 @@ New Tokens GLX_RENDERER_VENDOR_ID_MESA GLX_RENDERER_DEVICE_ID_MESA - Accepted as an attribute name in <*attrib_list> in - glXCreateContextAttribsARB: - - GLX_RENDERER_ID_MESA 0x818E - Additions to the OpenGL / WGL Specifications None. This specification is written for GLX. @@ -203,20 +198,6 @@ Additions to the GLX 1.4 Specification format as the string that would be returned by glGetString of GL_RENDERER. It may, however, have a different value. - - [Add to section section 3.3.7 "Rendering Contexts"] - - The attribute name GLX_RENDERER_ID_MESA specified the index of the render - against which the context should be created. The default value of - GLX_RENDERER_ID_MESA is 0. - - - [Add to list of errors for glXCreateContextAttribsARB in section section - 3.3.7 "Rendering Contexts"] - - * If the value of GLX_RENDERER_ID_MESA specifies a non-existent - renderer, BadMatch is generated. - Issues 1) How should the difference between on-card and GART memory be exposed? -- 2.30.2