From 9ea97097e5ae3d9979e6f72e44f72d665703bad8 Mon Sep 17 00:00:00 2001 From: Jason Merrill Date: Wed, 28 Feb 2018 16:34:07 -0500 Subject: [PATCH] PR c++/71784 - ICE with ref-qualifier and explicit specialization. * pt.c (determine_specialization): Check ref-qualifier. From-SVN: r258085 --- gcc/cp/ChangeLog | 5 +++++ gcc/cp/pt.c | 20 ++++++++++++++++---- gcc/testsuite/g++.dg/cpp0x/ref-qual18.C | 18 ++++++++++++++++++ 3 files changed, 39 insertions(+), 4 deletions(-) create mode 100644 gcc/testsuite/g++.dg/cpp0x/ref-qual18.C diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 40d7f873abf..be9b3fdcdd3 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,8 @@ +2018-02-28 Jason Merrill + + PR c++/71784 - ICE with ref-qualifier and explicit specialization. + * pt.c (determine_specialization): Check ref-qualifier. + 2018-02-28 Jakub Jelinek PR c++/84609 diff --git a/gcc/cp/pt.c b/gcc/cp/pt.c index 507675b4aae..73451195cd0 100644 --- a/gcc/cp/pt.c +++ b/gcc/cp/pt.c @@ -2163,10 +2163,17 @@ determine_specialization (tree template_id, that the const qualification is the same. Since get_bindings does not try to merge the "this" parameter, we must do the comparison explicitly. */ - if (DECL_NONSTATIC_MEMBER_FUNCTION_P (fn) - && !same_type_p (TREE_VALUE (fn_arg_types), - TREE_VALUE (decl_arg_types))) - continue; + if (DECL_NONSTATIC_MEMBER_FUNCTION_P (fn)) + { + if (!same_type_p (TREE_VALUE (fn_arg_types), + TREE_VALUE (decl_arg_types))) + continue; + + /* And the ref-qualification. */ + if (type_memfn_rqual (TREE_TYPE (decl)) + != type_memfn_rqual (TREE_TYPE (fn))) + continue; + } /* Skip the "this" parameter and, for constructors of classes with virtual bases, the VTT parameter. A @@ -2277,6 +2284,11 @@ determine_specialization (tree template_id, decl_arg_types)) continue; + if (DECL_NONSTATIC_MEMBER_FUNCTION_P (fn) + && (type_memfn_rqual (TREE_TYPE (decl)) + != type_memfn_rqual (TREE_TYPE (fn)))) + continue; + // If the deduced arguments do not satisfy the constraints, // this is not a candidate. if (flag_concepts && !constraints_satisfied_p (fn)) diff --git a/gcc/testsuite/g++.dg/cpp0x/ref-qual18.C b/gcc/testsuite/g++.dg/cpp0x/ref-qual18.C new file mode 100644 index 00000000000..aaa00b9cfc3 --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp0x/ref-qual18.C @@ -0,0 +1,18 @@ +// PR c++/71784 +// { dg-do compile { target c++11 } } + +template struct A { + template void f(U const&) & { } + template void f(U const&) && { } +}; + +template void A::f(int const&) &; +template void A::f(int const&) &&; + +template struct B { + void f(int const&) & { } + void f(int const&) && { } +}; + +template void B::f(int const&) &; +template void B::f(int const&) &&; -- 2.30.2