From 9ebce098585220299a78ecda84b145d16ee25bca Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Mon, 17 Jul 2017 12:20:41 +0200 Subject: [PATCH] re PR tree-optimization/81428 (ICE: in build_one_cst, at tree.c:2079 with -O2. Fixed point division.) PR tree-optimization/81428 * match.pd (X / X -> one): Don't optimize _Fract divisions, as 1 can't be built for those types. * gcc.dg/fixed-point/pr81428.c: New test. From-SVN: r250265 --- gcc/ChangeLog | 6 ++++++ gcc/match.pd | 5 +++-- gcc/testsuite/ChangeLog | 3 +++ gcc/testsuite/gcc.dg/fixed-point/pr81428.c | 9 +++++++++ 4 files changed, 21 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/fixed-point/pr81428.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index db3540155ef..0c279095cf4 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2017-07-17 Jakub Jelinek + + PR tree-optimization/81428 + * match.pd (X / X -> one): Don't optimize _Fract divisions, as 1 + can't be built for those types. + 2017-07-17 Georg-Johann Lay Remove stuff dead since r239246. diff --git a/gcc/match.pd b/gcc/match.pd index 4c64b21b463..979085aba5a 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -243,8 +243,9 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) /* X / X is one. */ (simplify (div @0 @0) - /* But not for 0 / 0 so that we can get the proper warnings and errors. */ - (if (!integer_zerop (@0)) + /* But not for 0 / 0 so that we can get the proper warnings and errors. + And not for _Fract types where we can't build 1. */ + (if (!integer_zerop (@0) && !ALL_FRACT_MODE_P (TYPE_MODE (type))) { build_one_cst (type); })) /* X / abs (X) is X < 0 ? -1 : 1. */ (simplify diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 141d035cf6d..4924b481427 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,5 +1,8 @@ 2017-07-17 Jakub Jelinek + PR tree-optimization/81428 + * gcc.dg/fixed-point/pr81428.c: New test. + PR tree-optimization/81365 * g++.dg/torture/pr81365.C: New test. diff --git a/gcc/testsuite/gcc.dg/fixed-point/pr81428.c b/gcc/testsuite/gcc.dg/fixed-point/pr81428.c new file mode 100644 index 00000000000..98f4b235718 --- /dev/null +++ b/gcc/testsuite/gcc.dg/fixed-point/pr81428.c @@ -0,0 +1,9 @@ +/* PR tree-optimization/81428 */ +/* { dg-do compile } */ +/* { dg-options "-O2" } */ + +void +foo (long _Fract *a, long _Fract *b) +{ + *b = *a / *a; +} -- 2.30.2